Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lead entity last active index #7343

Conversation

Projects
None yet
3 participants
@kuzmany
Copy link
Contributor

kuzmany commented Mar 21, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Remove index last_active_search from this PR #6279
This index already added by FieldModel https://github.com/kuzmany/mautic/blob/928661ba87ecc8970568dce899404cd9d09fe7ae/app/bundles/LeadBundle/Model/FieldModel.php#L494-L494

Yes, it caused a lot of ugly issues with php app/console d:s:u --force remove a lot of columns and indexes. Script fail because it's duplicate index statement and everything after this line is removed from db schema.

Discussed here #7167

Steps to test this PR:

  1. Code review is enought

@alanhartless alanhartless changed the base branch from staging to release-2.15.1 Mar 21, 2019

@alanhartless alanhartless merged commit 6c1d5fa into mautic:release-2.15.1 Mar 21, 2019

@npracht npracht added this to the 2.15.1 milestone Mar 29, 2019

@npracht npracht referenced this pull request Mar 29, 2019

Closed

Edit Contact - System 500 #7167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.