Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent destroySlots for code mode If builder was never loaded #7346

Merged
merged 4 commits into from Apr 12, 2019

Conversation

Projects
4 participants
@kuzmany
Copy link
Contributor

kuzmany commented Mar 25, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #7340
BC breaks?
Deprecations?

Description:

Noticed issues #7340
Error happen whe we never init builder with slots and will force use code mode.

On production server require regenerate assets php app/console mautic:assets:generate

Steps to reproduce the bug:

  1. Use firefox
  2. Create a new email (add object and name)
  3. Choose code mode
  4. Copy and paste this html
<!DOCTYPE html>
<html>
<body>
<h1>Test Heading</h1>
<p>Test paragraph.</p>
</body>
</html>
  1. Click on apply
  2. See that it still tries to load
    image
    And check the console inspector, you will see an error

Capture d’écran 2019-03-20 à 18 09 51

7. Repeat this step with google chrome and you won't get a problem.

Steps to test this PR:

  1. Load up this PR
  2. Repeat all steps
  3. Apply button should works properly
@johbuch
Copy link

johbuch left a comment

tested with mautibox
it works
thanks zdeno

@npracht npracht added the Code Review label Mar 28, 2019

@npracht npracht modified the milestones: 2.16.0, 2.15.2 Mar 28, 2019

@Enc3phale

This comment has been minimized.

Copy link
Contributor

Enc3phale commented Apr 2, 2019

Doesn't work because we have same error L.461

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Apr 2, 2019

@Enc3phale steps to reproduce are the same?

@Enc3phale

This comment has been minimized.

Copy link
Contributor

Enc3phale commented Apr 2, 2019

@kuzmany yes and same way to correct

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Apr 2, 2019

@Enc3phale thank you, try now

@npracht

npracht approved these changes Apr 4, 2019

Copy link
Member

npracht left a comment

Working properly with last modification

@npracht npracht added this to Ready to Commit (passed testing) in Mautic 2 Apr 4, 2019

@kuzmany kuzmany merged commit c14abfc into mautic:staging Apr 12, 2019

2 checks passed

Scrutinizer Analysis: 1 new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.