Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with not recognizing IP ranges in the do not track list #7388

Merged
merged 2 commits into from May 8, 2019

Conversation

Projects
4 participants
@alanhartless
Copy link
Contributor

commented Apr 4, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature?
Automated tests included? Y
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

When using IP ranges in the list of IPs to not track in Mautic's configuration (i.e. 111.111.0.0/12), Mautic used the blocked IP to compare against itself so the given IP was never detected as not trackable. This fixes that and includes unit tests for each of the supported scenarios.

Steps to reproduce the bug:

  1. See the tests

Steps to test this PR:

  1. Code review and run the new unit tests

@alanhartless alanhartless added the Bug label Apr 4, 2019

@npracht npracht added this to the 2.15.2 milestone Apr 5, 2019

@npracht npracht added this to Ready to Test (first time) in Mautic 2 Apr 5, 2019

@IV2KBMoFxYIA

This comment has been minimized.

Copy link

commented Apr 15, 2019

we tried this in our local instance and we couldn't restrict our internal 172.17.x subnet traffic.

@kuzmany

kuzmany approved these changes May 8, 2019

@kuzmany kuzmany merged commit dce7322 into mautic:staging May 8, 2019

2 checks passed

Scrutinizer Analysis: 4 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Test (first time) to Merged May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.