Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contact ID only if contact exists #7414

Merged
merged 1 commit into from May 8, 2019

Conversation

Projects
3 participants
@escopecz
Copy link
Member

commented Apr 12, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? N
Automated tests included? N
Related user documentation PR URL /
Related developer documentation PR URL /
Issues addressed (#s or URLs) /
BC breaks? N
Deprecations? N

Description:

Ensure the contact exist during unsubscribe action before asking for his ID. Fixing error

Call to a member function getId() on null" at app/bundles/EmailBundle/Controller/PublicController.php line 183

Steps to reproduce the bug:

  1. Sent an email with unsubscribe link to a contact.
  2. Delete that contact.
  3. Click on the unsubscribe link - 500 error page

Steps to test this PR:

  1. Click on the unsubscribe page again - shows successful unsubscription.

@npracht npracht added this to the 2.15.2 milestone Apr 12, 2019

@npracht npracht added this to Ready to Test (first time) in Mautic 2 Apr 12, 2019

@kuzmany

kuzmany approved these changes May 8, 2019

@kuzmany kuzmany merged commit 6ac6baf into mautic:staging May 8, 2019

2 checks passed

Scrutinizer Analysis: 1 new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Test (first time) to Merged May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.