Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some admin menu items are visible for user with not permissions #7425

Closed
wants to merge 3 commits into from

Conversation

@informatico-madrid
Copy link

informatico-madrid commented Apr 16, 2019

handleAccessCheck function return integer 0. but handleChecks function check for boolean value.

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? yes
New feature? no
Automated tests included? no
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Steps to reproduce the bug:

  1. log in with user that have a rol with only "own" mail permissions
  2. there are some UI links that the user should not see. and if you click in a 403 forbidden is trigged.

Steps to test this PR:

  1. Load up this PR

List deprecations along with the new alternative:

List backwards compatibility breaks:

handleAccessCheck function return integer 0. but handleChecks function check for boolean value.
@Woeler

This comment has been minimized.

Copy link
Member

Woeler commented Apr 24, 2019

Please provide more information on how to replicate and test.

@informatico-madrid

This comment has been minimized.

Copy link
Author

informatico-madrid commented Apr 24, 2019

i update my initial post. with:
steps to reproduce:

  1. log in with user that have a rol with only "own" mail permissions
  2. there are some UI links that the user should not see. and if you click in a 403 forbidden is trigged.
remove unuseful line
@Woeler Woeler added the Bug label Apr 24, 2019
@RCheesley RCheesley added this to the 2.16.1 milestone Mar 9, 2020
@npracht npracht added this to Backlog in Mautic 2 Mar 10, 2020
@RCheesley RCheesley moved this from Backlog to Ready to test in Mautic 2 Mar 18, 2020
@RCheesley

This comment has been minimized.

Copy link
Member

RCheesley commented Mar 18, 2020

I've just tried to replicate this before applying the patch, but I am not able to. The behaviour is what I would expect - see screencast here: https://youtu.be/DkA2ItnAgdc

I think therefore that this PR is outdated or no longer relevant, because I can't reproduce the 403 errors the OP mentions. Therefore propose closing it @dennisameling

@RCheesley RCheesley closed this Mar 18, 2020
Mautic 2 automation moved this from Ready to test to Merged Mar 18, 2020
@mautibot

This comment has been minimized.

Copy link

mautibot commented Mar 20, 2020

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/announcing-mautic-2-16-1-beta/13438/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mautic 2
  
Merged
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.