Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where campaign's email replies were not recognized #7445

Merged
merged 6 commits into from May 8, 2019

Conversation

Projects
3 participants
@alanhartless
Copy link
Contributor

commented Apr 18, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This was hard to reproduce and required just the right HTML. I was only able to reproduce it once but was able to grab the HTML that did and so created a unit test. In some cases, the HTML caused the preg_match to include HTML form the unsubscribe link so the stat wasn't found. This PR thus updates the regex to be more strict so that it only matches the gif's tracking hash ID.

The PR also prevented a PHP notice and set timeouts for all imap functions to prevent locked web requests due to bad ports.

Steps to reproduce the bug:

  1. Not sure. I used apple mail to reply to the email. But subsequent attempts to reproduce failed.

For the timeout issue, I was able to reproduce it by configuring an open non-imap port like 80. I couldn't reload the config after that.

Steps to test this PR:

  1. Run the new unit test.
  2. Configure the imap settings with a non-imap but open port like 80. After 15 seconds, it should stop trying to connect and load the configuration page.

@npracht npracht added this to the 2.15.2 milestone Apr 18, 2019

@npracht npracht added this to Ready to Test (first time) in Mautic 2 Apr 18, 2019

@kuzmany kuzmany self-assigned this May 6, 2019

@kuzmany

kuzmany approved these changes May 6, 2019

@escopecz escopecz moved this from Ready to Test (first time) to Ready to Commit (passed testing) in Mautic 2 May 6, 2019

@kuzmany kuzmany merged commit 9d7c0e3 into mautic:staging May 8, 2019

2 checks passed

Scrutinizer Analysis: 2 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.