Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix router for dev enviroment #7457

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
3 participants
@kuzmany
Copy link
Contributor

commented Apr 21, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Based on this PR and discution
https://github.com/mautic/mautic/pull/7193/files#r275331511

Steps to test this PR:

  1. Load up this PR
  2. Try If Mautibox works properly

@kuzmany kuzmany added this to the 2.15.2 milestone Apr 21, 2019

@heathdutton

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

Not sure how base_url works in all cases... I commented out that line by an override in Mautibox for the time being mautibox/mautibox@c5145a4

But I think more logic needs to be here to check that the url doesn't already carry the index_dev.php and to embed it in the correct location. I don't think it's quite so simple. But hey I could be wrong 🤷‍♂️

@npracht npracht added this to Ready to Test (first time) in Mautic 2 Apr 25, 2019

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2019

@alanhartless @escopecz could somebody tak a look
I am using on my dev enviroment few weeks and works properly

@escopecz escopecz moved this from Ready to Test (first time) to Ready to Test (confirmation) in Mautic 2 May 13, 2019

Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) May 13, 2019

@escopecz
Copy link
Member

left a comment

it makes more sense than the previous version 👍

@escopecz escopecz moved this from Ready to Test (first time) to Ready to Test (confirmation) in Mautic 2 May 13, 2019

@kuzmany kuzmany merged commit 311325b into mautic:staging May 13, 2019

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Test (confirmation) to Merged May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.