Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added identical comparison for boolean for email dynamic content #7468

Merged

Conversation

@kuzmany
Copy link
Contributor

commented Apr 24, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #7451
BC breaks?
Deprecations?

Description:

This fix for issue #7451
Email dynamic content compare bool type of filter and value in wrong way.

Before: Not set custom bool field not equal 0 - return false
After: Return true ("not set" is not equal to 0)

Steps to reproduce the bug:

  1. Create a boolean custom field leave the default value to blank
  2. Create an email with a dynamic content using the filter not equal to No
    image
  3. Send the email to the contact, he will receive the default variant and not the one with the filter

Steps to test this PR:

  1. Load up this PR
  2. Repeat all steps
  3. "not set" custom field with condition not equal to No should return true)
@florentpetitjean
Copy link

left a comment

just tested and it works 👍
great job

@npracht npracht added this to Ready to Test (first time) in Mautic 2 Apr 25, 2019

@escopecz escopecz moved this from Ready to Test (first time) to Ready to Test (confirmation) in Mautic 2 Apr 26, 2019

Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) May 7, 2019

@escopecz escopecz moved this from Ready to Test (first time) to Ready to Commit (passed testing) in Mautic 2 May 7, 2019

@kuzmany kuzmany merged commit d30a6f0 into mautic:staging May 8, 2019

2 checks passed

Scrutinizer 1 new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.