Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intl infinite loop fix #7470

Merged
merged 3 commits into from May 2, 2019

Conversation

Projects
5 participants
@escopecz
Copy link
Member

commented Apr 25, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? N
Automated tests included? N
Related user documentation PR URL /
Related developer documentation PR URL /
Issues addressed (#s or URLs) #7408
BC breaks? N
Deprecations? N

Description:

The symfony/intl:2.8 has a bug that cause an infinite loop on some PHP versions. Since version 2.8 that Mautic uses is in the "security fixes only" mode and we cannot upgrade to 3.4 without BC breaks we forked the intl package, fixed the issue and tell Composer to use our fork instead of the original.

I can see that the \Symfony\Component\Intl\Locale class contains the fix and when I run

$ composer show symfony/intl -v

I can see

source : [git] https://github.com/mautic/intl.git 236c4eb3d12813f766d6b52d23b5677bf0a9840f

Steps to reproduce the bug:

  1. I don't quite know when it happens. I asked in the issue but did not get any answer. But guys in the issue provided info about what needs to change to fix the issue and several Mauticans confirmed.

Steps to test this PR:

  1. Load up this PR or run composer install on your local Mautic.
@luizeof

This comment has been minimized.

Copy link

commented Apr 25, 2019

Tested with Docker Mautic (PHP 7.1.27) and Docker Mautic Beta (7.2) and this bug doesn't happen

@npracht npracht added this to the 2.15.2 milestone May 2, 2019

@npracht npracht added this to Ready to Commit (passed testing) in Mautic 2 May 2, 2019

@kuzmany kuzmany merged commit a780763 into mautic:staging May 2, 2019

2 checks passed

Scrutinizer Analysis: 1 new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged May 2, 2019

@escopecz escopecz deleted the mautic-inc:intl-infinite-loop branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.