Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook fail notification by e-mail #7488

Open
wants to merge 18 commits into
base: staging
from

Conversation

Projects
None yet
2 participants
@hluchas
Copy link
Contributor

commented Apr 30, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature? Y
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Mautic user needs to be notified about failing webhook by e-mail.

Steps to reproduce the bug:

  1. Create webhook targeting to not existing url connected to edit contact event.
  2. Temporarily decrease value webhook_disable_limit to 1 in app/bundles/WebhookBundle/Config/config.php
  3. Edit and save contact.
  4. Webhook is unpublished, notification send, but no e-mail received.

Steps to test this PR:

  1. Load up this PR
  2. Publish webhook.
  3. Same as reproduction steps, but you will receive e-mail.
  4. Test e-mail link redirection on Mautic app side
@npracht

This comment has been minimized.

Copy link
Member

commented May 2, 2019

Hi @hluchas can you have a look at Travis ?

@hluchas

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

Thank you @npracht . Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.