Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow html to textarea custom field #7489

Closed
wants to merge 8 commits into from
Closed

Allow html to textarea custom field #7489

wants to merge 8 commits into from

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Apr 30, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR bring option to allow HTML in text area custom contact/company field.
We have many request store HTML to contact and then work with this content.

image

Steps to test this PR:

  1. Load up this PR
  2. Create textarea contact field and enable allow HTML
  3. Create/edit contact and see If this textarea work also with HTML

image

@kuzmany kuzmany added ready-to-test PR's that are ready to test enhancement Any improvement to an existing feature or functionality labels Apr 30, 2019
@kuzmany kuzmany added this to the 2.16.0 milestone Apr 30, 2019
npracht
npracht approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@npracht npracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works with last version !

@npracht npracht added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels May 20, 2019
@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Aug 15, 2019
@npracht npracht modified the milestone: 2.16.0 Jan 23, 2020
@npracht npracht added needs-rebase PR's that need to be rebased and removed pending-test-confirmation PR's that require one test before they can be merged labels Apr 6, 2020
@npracht npracht added this to the 3.1.0 milestone Apr 6, 2020
@npracht
Copy link
Member

npracht commented Apr 6, 2020

Hi there!
It has been decided to not create any extra Mautic 2 minor versions (which means no more features in M2) knowing that Mautic 3 is coming very soon.

We now want to integrate your contribution in the Mautic 3 roadmap as 3.1.0 candidate.

How to do?

  1. Check if your feature or enhancement is still missing and relevant in Mautic 3
  2. If Yes: rebase your PR against the 3.x branch
  3. If No: please consider closing your PR if you are absolutely sure that the feature has made it into Mautic 3 already

Please report results by commenting on your PR to make us administration easier.

You can more information on how to do all of that on this blog post "Getting you PR ready for Mautic 3".

@npracht npracht added this to Pending feedback in 3.1.0 Apr 6, 2020
@kuzmany kuzmany mentioned this pull request Apr 9, 2020
Open
@mohit-rocks mohit-rocks mentioned this pull request Apr 18, 2020
Merged
@npracht
Copy link
Member

npracht commented Apr 18, 2020

Closed in favor of #8706 which is rebased for M3

@npracht npracht closed this Apr 18, 2020
@npracht npracht removed this from the 3.1.0 milestone Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npracht npracht npracht approved these changes

Assignees
No one assigned
Labels
enhancement Any improvement to an existing feature or functionality needs-rebase PR's that need to be rebased
Projects
No open projects
3.1.0
  
Pending feedback
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kuzmany @npracht