Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Or statement for get list of lead Ids by unique field data #7501

Merged
merged 2 commits into from May 12, 2019

Conversation

Projects
None yet
2 participants
@kuzmany
Copy link
Contributor

commented May 7, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

On working with custom deduplicate
I notice there is mismatch with getLeadsByUniqueFields function.
Few lines below we use same logic but with andWhere statement. I think It's incorrect

Steps to test this PR:

  1. This PR is just for code review

@kuzmany kuzmany added this to the 2.15.2 milestone May 7, 2019

@escopecz

This comment has been minimized.

Copy link
Member

commented May 7, 2019

OR makes more sense to me. We need only 1 match to identify a contact.

@kuzmany kuzmany changed the title Add andWhere to getLeadIdsByUniqueFields Or statement for get list of lead Ids by unique field data May 10, 2019

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

@escopecz now should be correct. Take a look and please approve it ;)

@kuzmany kuzmany merged commit b3541ac into mautic:staging May 12, 2019

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.