Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugin create own deduplicate logic #7502

Open
wants to merge 10 commits into
base: staging
from

Conversation

Projects
None yet
1 participant
@kuzmany
Copy link
Contributor

commented May 7, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Common mautic:contacts:deduplicate already deduplicate contacts by unique fields from configurations. But sometimes we need custom check for duplications (for example based on firstname/lastname/phone). This PR added dispatcher to checkForDuplicateContacts method allow load duplicate contacts by plugin.
This allow also create own command (for example mautic:contacts:deduplicate:custom) along with core one.

Steps to test this PR:

  1. Install and setup MauticCustomDeduplicateBundle https://github.com/mtcextendee/mautic-custom-deduplicate-bundle
  2. Choose in plugins settings:
    firstname, lastname, phone
    and not empty email
  3. Create two contacts without email but with same firstname, lastname, and phone.
  4. Run php app/console mautic:contacts:deduplicate:custom
  5. See If contacts were merged
  6. Then create two contacts again
  7. Go to Mautic > Contacts
  8. Run Custom deduplicate from menu
    image
  9. Wait and then see If you have at least two notification in notification area (started, finished)
    image
  10. Check If contacts were merged

kuzmany added some commits May 7, 2019

@kuzmany kuzmany changed the title Option to deduplicate by plugin Option to create own listenet to duplicates for deduplicate command May 7, 2019

@kuzmany kuzmany changed the title Option to create own listenet to duplicates for deduplicate command Option to create own listener to duplicates for deduplicate command May 7, 2019

kuzmany added some commits May 7, 2019

@kuzmany kuzmany changed the title Option to create own listener to duplicates for deduplicate command Allow plugin create own deduplicate logic May 7, 2019

kuzmany added some commits May 7, 2019

@kuzmany kuzmany added Ready To Test and removed WIP labels May 8, 2019

@kuzmany kuzmany added this to the 2.16.0 milestone May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.