Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom contacts columns #7511

Merged
merged 8 commits into from Nov 21, 2020
Merged

Custom contacts columns #7511

merged 8 commits into from Nov 21, 2020

Conversation

@kuzmany
Copy link
Member

@kuzmany kuzmany commented May 10, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) This PR closes #120
BC breaks?
Deprecations?

Description:

This PR added option custom contact's columns from configurations.

image

Steps to test this PR:

  1. Load up this PR
  2. You should see default columns (like before)
  3. Go to Configurations > Contact Settings tag and see new Contact List Settings part
  4. Change some columns and save
  5. Go to contacts and see If your changes was applied

image

Copy link

@MauriceW2 MauriceW2 left a comment

Just tested this PR twice on Mautic v2.15.1 and v2.15.2-beta and mautibox.com/7511 and it works as expected.

Loading

@MauriceW2
Copy link

@MauriceW2 MauriceW2 commented Jul 28, 2019

It works as expected, however, I see 4 lines in the error logging:

LINE 1
[2019-07-28 14:54:36] mautic.NOTICE: PHP Notice - Undefined variable: columns - in file /var/www/clients/client2/web13/web/mtc/app/bundles/LeadBundle/Views/Lead/list_rows.html.php - at line 68 {"mauticTemplateVars":{"app":"[object] (Symfony\\Bundle\\FrameworkBundle\\Templating\\GlobalVariables: {})","items":{"200":"[object] (Mautic\\LeadBundle\\Entity\\Lead: Mautic\\LeadBundle\\Entity\\Lead with ID #200)"},"noContactList":[],"permissions":{"lead:leads:viewown":true,"lead:leads:viewother":true,"lead:leads:create":true,"lead:leads:editown":true,"lead:leads:editother":true,"lead:leads:deleteown":true,"lead:leads:deleteother":true},"security":"[object] (Mautic\\CoreBundle\\Security\\Permissions\\CorePermissions: {})","highlight":true,"mauticTemplate":"MauticLeadBundle:Lead:list_rows.html.php","view":"[object] (Mautic\\CoreBundle\\Templating\\Engine\\PhpEngine: {})"},"app":"[object] (Symfony\\Bundle\\FrameworkBundle\\Templating\\GlobalVariables: {})","items":{"200":"[object] (Mautic\\LeadBundle\\Entity\\Lead: Mautic\\LeadBundle\\Entity\\Lead with ID #200)"},"noContactList":[],"permissions":{"lead:leads:viewown":true,"lead:leads:viewother":true,"lead:leads:create":true,"lead:leads:editown":true,"lead:leads:editother":true,"lead:leads:deleteown":true,"lead:leads:deleteother":true},"security":"[object] (Mautic\\CoreBundle\\Security\\Permissions\\CorePermissions: {})","highlight":true,"mauticTemplate":"MauticLeadBundle:Lead:list_rows.html.php","view":"[object] (Mautic\\CoreBundle\\Templating\\Engine\\PhpEngine: {})","item":"[object] (Mautic\\LeadBundle\\Entity\\Lead: Mautic\\LeadBundle\\Entity\\Lead with ID #200)","fields":{"core":{"last_active":{"id":"19","label":"Date Last Active","alias":"last_active","type":"datetime","group":"core","object":"lead","is_fixed":"1","value":null},"firstname":{"id":"2","label":"First Name","alias":"firstname","type":"text","group":"core","object":"lead","is_fixed":"1","value":"Mieke"},"email":{"id":"6","label":"Email","alias":"email","type":"email","group":"core","object":"lead","is_fixed":"1","value":"miekearendse26@gmail.com"},"phone":{"id":"8","label":"Phone","alias":"phone","type":"tel","group":"core","object":"lead","is_fixed":"1","value":null},"timezone":{"id":"18","label":"mautic.lead.field.timezone","alias":"timezone","type":"timezone","group":"core","object":"lead","is_fixed":"1","value":null},"fb_form_id":{"id":"45","label":"FB Form ID","alias":"fb_form_id","type":"text","group":"core","object":"lead","is_fixed":"0","value":"917289431982736"},"fb_campaign_name":{"id":"46","label":"FB Campaign Name","alias":"fb_campaign_name","type":"text","group":"core","object":"lead","is_fixed":"0","value":"HypnoSlank - Webinar - Lead Ads 1"},"fb_campaign_id":{"id":"47","label":"FB Campaign ID","alias":"fb_campaign_id","type":"text","group":"core","object":"lead","is_fixed":"0","value":"23843291186700180"},"fb_adset_name":{"id":"48","label":"FB Adset Name","alias":"fb_adset_name","type":"text","group":"core","object":"lead","is_fixed":"0","value":"Targeting - 27/6 - A (micro adjustment 1)"},"fb_adset_id":{"id":"49","label":"FB Adset ID","alias":"fb_adset_id","type":"text","group":"core","object":"lead","is_fixed":"0","value":"23843483158650180"},"fb_ad_name":{"id":"50","label":"FB Ad Name","alias":"fb_ad_name","type":"text","group":"core","object":"lead","is_fixed":"0","value":"Trancewerk - Webinar (ED) Lead generation"},"fb_ad_id":{"id":"51","label":"FB Ad ID","alias":"fb_ad_id","type":"text","group":"core","object":"lead","is_fixed":"0","value":"23843483158660180"},"last_ordered_skus":{"id":"52","label":"Last Ordered SKUs","alias":"last_ordered_skus","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"all_ordered_skus":{"id":"53","label":"All Ordered SKUs","alias":"all_ordered_skus","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"last_order_number":{"id":"54","label":"Last Order Number","alias":"last_order_number","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"last_ordered_products":{"id":"55","label":"Last Ordered Products","alias":"last_ordered_products","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"last_used_payment_method":{"id":"56","label":"Last Used Payment Method","alias":"last_used_payment_method","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"last_order_status":{"id":"57","label":"Last Order Status","alias":"last_order_status","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"abandoned_cart_skus":{"id":"58","label":"Abandoned Cart SKUs","alias":"abandoned_cart_skus","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"working_day":{"id":"60","label":"Working Day","alias":"working_day","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"problems":{"id":"61","label":"Problems","alias":"problems","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"goal":{"id":"62","label":"Goal","alias":"goal","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"gender":{"id":"63","label":"Gender","alias":"gender","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"age_category":{"id":"64","label":"Age Category","alias":"age_category","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"desired_weight":{"id":"65","label":"Desired Weight","alias":"desired_weight","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"unsubscribe_reason":{"id":"66","label":"Unsubscribe Reason","alias":"unsubscribe_reason","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_registration_date":{"id":"67","label":"Webinar Registration Date+Time","alias":"webinar_registration_date","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_day":{"id":"68","label":"Webinar Day","alias":"webinar_day","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_date":{"id":"69","label":"Webinar Date","alias":"webinar_date","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_expiration_day":{"id":"70","label":"Webinar Expiration Day","alias":"webinar_expiration_day","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_expiration_date":{"id":"71","label":"Webinar Expiration Date","alias":"webinar_expiration_date","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_time":{"id":"72","label":"Webinar Time","alias":"webinar_time","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_timezone":{"id":"73","label":"Webinar TimeZone","alias":"webinar_timezone","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_thank_you_url":{"id":"74","label":"Webinar Thank You URL","alias":"webinar_thank_you_url","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_live_room_url":{"id":"75","label":"Webinar Live Room URL","alias":"webinar_live_room_url","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_replay_room_url":{"id":"76","label":"Webinar Replay Room URL","alias":"webinar_replay_room_url","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"todays_date":{"id":"78","label":"Today's Date","alias":"todays_date","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"office_hours":{"id":"79","label":"Office Hours","alias":"office_hours","type":"number","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_date_datefield":{"id":"81","label":"Webinar Date (datefield)","alias":"webinar_date_datefield","type":"date","group":"core","object":"lead","is_fixed":"0","value":null}},"social":[],"personal":[],"professional":[]},"hasEditAccess":true,"custom":[{"attr":{"data-toggle":"ajaxmodal","data-target":"#MauticSharedModal","data-header":"Send a custom email to miekearendse26@gmail.com","href":"/mtc/s/contacts/email/200?list=1"},"btnText":"mautic.lead.email.send_email","iconClass":"fa fa-send"}]} []

LINE 2
[2019-07-28 14:54:36] mautic.WARNING: PHP Warning - array_flip() expects parameter 1 to be array, null given - in file /var/www/clients/client2/web13/web/mtc/app/bundles/LeadBundle/Views/Lead/list_rows.html.php - at line 68 {"mauticTemplateVars":{"app":"[object] (Symfony\\Bundle\\FrameworkBundle\\Templating\\GlobalVariables: {})","items":{"200":"[object] (Mautic\\LeadBundle\\Entity\\Lead: Mautic\\LeadBundle\\Entity\\Lead with ID #200)"},"noContactList":[],"permissions":{"lead:leads:viewown":true,"lead:leads:viewother":true,"lead:leads:create":true,"lead:leads:editown":true,"lead:leads:editother":true,"lead:leads:deleteown":true,"lead:leads:deleteother":true},"security":"[object] (Mautic\\CoreBundle\\Security\\Permissions\\CorePermissions: {})","highlight":true,"mauticTemplate":"MauticLeadBundle:Lead:list_rows.html.php","view":"[object] (Mautic\\CoreBundle\\Templating\\Engine\\PhpEngine: {})"},"app":"[object] (Symfony\\Bundle\\FrameworkBundle\\Templating\\GlobalVariables: {})","items":{"200":"[object] (Mautic\\LeadBundle\\Entity\\Lead: Mautic\\LeadBundle\\Entity\\Lead with ID #200)"},"noContactList":[],"permissions":{"lead:leads:viewown":true,"lead:leads:viewother":true,"lead:leads:create":true,"lead:leads:editown":true,"lead:leads:editother":true,"lead:leads:deleteown":true,"lead:leads:deleteother":true},"security":"[object] (Mautic\\CoreBundle\\Security\\Permissions\\CorePermissions: {})","highlight":true,"mauticTemplate":"MauticLeadBundle:Lead:list_rows.html.php","view":"[object] (Mautic\\CoreBundle\\Templating\\Engine\\PhpEngine: {})","item":"[object] (Mautic\\LeadBundle\\Entity\\Lead: Mautic\\LeadBundle\\Entity\\Lead with ID #200)","fields":{"core":{"last_active":{"id":"19","label":"Date Last Active","alias":"last_active","type":"datetime","group":"core","object":"lead","is_fixed":"1","value":null},"firstname":{"id":"2","label":"First Name","alias":"firstname","type":"text","group":"core","object":"lead","is_fixed":"1","value":"Mieke"},"email":{"id":"6","label":"Email","alias":"email","type":"email","group":"core","object":"lead","is_fixed":"1","value":"miekearendse26@gmail.com"},"phone":{"id":"8","label":"Phone","alias":"phone","type":"tel","group":"core","object":"lead","is_fixed":"1","value":null},"timezone":{"id":"18","label":"mautic.lead.field.timezone","alias":"timezone","type":"timezone","group":"core","object":"lead","is_fixed":"1","value":null},"fb_form_id":{"id":"45","label":"FB Form ID","alias":"fb_form_id","type":"text","group":"core","object":"lead","is_fixed":"0","value":"917289431982736"},"fb_campaign_name":{"id":"46","label":"FB Campaign Name","alias":"fb_campaign_name","type":"text","group":"core","object":"lead","is_fixed":"0","value":"HypnoSlank - Webinar - Lead Ads 1"},"fb_campaign_id":{"id":"47","label":"FB Campaign ID","alias":"fb_campaign_id","type":"text","group":"core","object":"lead","is_fixed":"0","value":"23843291186700180"},"fb_adset_name":{"id":"48","label":"FB Adset Name","alias":"fb_adset_name","type":"text","group":"core","object":"lead","is_fixed":"0","value":"Targeting - 27/6 - A (micro adjustment 1)"},"fb_adset_id":{"id":"49","label":"FB Adset ID","alias":"fb_adset_id","type":"text","group":"core","object":"lead","is_fixed":"0","value":"23843483158650180"},"fb_ad_name":{"id":"50","label":"FB Ad Name","alias":"fb_ad_name","type":"text","group":"core","object":"lead","is_fixed":"0","value":"Trancewerk - Webinar (ED) Lead generation"},"fb_ad_id":{"id":"51","label":"FB Ad ID","alias":"fb_ad_id","type":"text","group":"core","object":"lead","is_fixed":"0","value":"23843483158660180"},"last_ordered_skus":{"id":"52","label":"Last Ordered SKUs","alias":"last_ordered_skus","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"all_ordered_skus":{"id":"53","label":"All Ordered SKUs","alias":"all_ordered_skus","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"last_order_number":{"id":"54","label":"Last Order Number","alias":"last_order_number","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"last_ordered_products":{"id":"55","label":"Last Ordered Products","alias":"last_ordered_products","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"last_used_payment_method":{"id":"56","label":"Last Used Payment Method","alias":"last_used_payment_method","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"last_order_status":{"id":"57","label":"Last Order Status","alias":"last_order_status","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"abandoned_cart_skus":{"id":"58","label":"Abandoned Cart SKUs","alias":"abandoned_cart_skus","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"working_day":{"id":"60","label":"Working Day","alias":"working_day","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"problems":{"id":"61","label":"Problems","alias":"problems","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"goal":{"id":"62","label":"Goal","alias":"goal","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"gender":{"id":"63","label":"Gender","alias":"gender","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"age_category":{"id":"64","label":"Age Category","alias":"age_category","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"desired_weight":{"id":"65","label":"Desired Weight","alias":"desired_weight","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"unsubscribe_reason":{"id":"66","label":"Unsubscribe Reason","alias":"unsubscribe_reason","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_registration_date":{"id":"67","label":"Webinar Registration Date+Time","alias":"webinar_registration_date","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_day":{"id":"68","label":"Webinar Day","alias":"webinar_day","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_date":{"id":"69","label":"Webinar Date","alias":"webinar_date","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_expiration_day":{"id":"70","label":"Webinar Expiration Day","alias":"webinar_expiration_day","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_expiration_date":{"id":"71","label":"Webinar Expiration Date","alias":"webinar_expiration_date","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_time":{"id":"72","label":"Webinar Time","alias":"webinar_time","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_timezone":{"id":"73","label":"Webinar TimeZone","alias":"webinar_timezone","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_thank_you_url":{"id":"74","label":"Webinar Thank You URL","alias":"webinar_thank_you_url","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_live_room_url":{"id":"75","label":"Webinar Live Room URL","alias":"webinar_live_room_url","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_replay_room_url":{"id":"76","label":"Webinar Replay Room URL","alias":"webinar_replay_room_url","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"todays_date":{"id":"78","label":"Today's Date","alias":"todays_date","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"office_hours":{"id":"79","label":"Office Hours","alias":"office_hours","type":"number","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_date_datefield":{"id":"81","label":"Webinar Date (datefield)","alias":"webinar_date_datefield","type":"date","group":"core","object":"lead","is_fixed":"0","value":null}},"social":[],"personal":[],"professional":[]},"hasEditAccess":true,"custom":[{"attr":{"data-toggle":"ajaxmodal","data-target":"#MauticSharedModal","data-header":"Send a custom email to miekearendse26@gmail.com","href":"/mtc/s/contacts/email/200?list=1"},"btnText":"mautic.lead.email.send_email","iconClass":"fa fa-send"}]} []

LINE 3
[2019-07-28 14:54:36] mautic.NOTICE: PHP Notice - Undefined variable: columns - in file /var/www/clients/client2/web13/web/mtc/app/bundles/LeadBundle/Views/Lead/list_rows.html.php - at line 69 {"mauticTemplateVars":{"app":"[object] (Symfony\\Bundle\\FrameworkBundle\\Templating\\GlobalVariables: {})","items":{"200":"[object] (Mautic\\LeadBundle\\Entity\\Lead: Mautic\\LeadBundle\\Entity\\Lead with ID #200)"},"noContactList":[],"permissions":{"lead:leads:viewown":true,"lead:leads:viewother":true,"lead:leads:create":true,"lead:leads:editown":true,"lead:leads:editother":true,"lead:leads:deleteown":true,"lead:leads:deleteother":true},"security":"[object] (Mautic\\CoreBundle\\Security\\Permissions\\CorePermissions: {})","highlight":true,"mauticTemplate":"MauticLeadBundle:Lead:list_rows.html.php","view":"[object] (Mautic\\CoreBundle\\Templating\\Engine\\PhpEngine: {})"},"app":"[object] (Symfony\\Bundle\\FrameworkBundle\\Templating\\GlobalVariables: {})","items":{"200":"[object] (Mautic\\LeadBundle\\Entity\\Lead: Mautic\\LeadBundle\\Entity\\Lead with ID #200)"},"noContactList":[],"permissions":{"lead:leads:viewown":true,"lead:leads:viewother":true,"lead:leads:create":true,"lead:leads:editown":true,"lead:leads:editother":true,"lead:leads:deleteown":true,"lead:leads:deleteother":true},"security":"[object] (Mautic\\CoreBundle\\Security\\Permissions\\CorePermissions: {})","highlight":true,"mauticTemplate":"MauticLeadBundle:Lead:list_rows.html.php","view":"[object] (Mautic\\CoreBundle\\Templating\\Engine\\PhpEngine: {})","item":"[object] (Mautic\\LeadBundle\\Entity\\Lead: Mautic\\LeadBundle\\Entity\\Lead with ID #200)","fields":{"core":{"last_active":{"id":"19","label":"Date Last Active","alias":"last_active","type":"datetime","group":"core","object":"lead","is_fixed":"1","value":null},"firstname":{"id":"2","label":"First Name","alias":"firstname","type":"text","group":"core","object":"lead","is_fixed":"1","value":"Mieke"},"email":{"id":"6","label":"Email","alias":"email","type":"email","group":"core","object":"lead","is_fixed":"1","value":"miekearendse26@gmail.com"},"phone":{"id":"8","label":"Phone","alias":"phone","type":"tel","group":"core","object":"lead","is_fixed":"1","value":null},"timezone":{"id":"18","label":"mautic.lead.field.timezone","alias":"timezone","type":"timezone","group":"core","object":"lead","is_fixed":"1","value":null},"fb_form_id":{"id":"45","label":"FB Form ID","alias":"fb_form_id","type":"text","group":"core","object":"lead","is_fixed":"0","value":"917289431982736"},"fb_campaign_name":{"id":"46","label":"FB Campaign Name","alias":"fb_campaign_name","type":"text","group":"core","object":"lead","is_fixed":"0","value":"HypnoSlank - Webinar - Lead Ads 1"},"fb_campaign_id":{"id":"47","label":"FB Campaign ID","alias":"fb_campaign_id","type":"text","group":"core","object":"lead","is_fixed":"0","value":"23843291186700180"},"fb_adset_name":{"id":"48","label":"FB Adset Name","alias":"fb_adset_name","type":"text","group":"core","object":"lead","is_fixed":"0","value":"Targeting - 27/6 - A (micro adjustment 1)"},"fb_adset_id":{"id":"49","label":"FB Adset ID","alias":"fb_adset_id","type":"text","group":"core","object":"lead","is_fixed":"0","value":"23843483158650180"},"fb_ad_name":{"id":"50","label":"FB Ad Name","alias":"fb_ad_name","type":"text","group":"core","object":"lead","is_fixed":"0","value":"Trancewerk - Webinar (ED) Lead generation"},"fb_ad_id":{"id":"51","label":"FB Ad ID","alias":"fb_ad_id","type":"text","group":"core","object":"lead","is_fixed":"0","value":"23843483158660180"},"last_ordered_skus":{"id":"52","label":"Last Ordered SKUs","alias":"last_ordered_skus","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"all_ordered_skus":{"id":"53","label":"All Ordered SKUs","alias":"all_ordered_skus","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"last_order_number":{"id":"54","label":"Last Order Number","alias":"last_order_number","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"last_ordered_products":{"id":"55","label":"Last Ordered Products","alias":"last_ordered_products","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"last_used_payment_method":{"id":"56","label":"Last Used Payment Method","alias":"last_used_payment_method","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"last_order_status":{"id":"57","label":"Last Order Status","alias":"last_order_status","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"abandoned_cart_skus":{"id":"58","label":"Abandoned Cart SKUs","alias":"abandoned_cart_skus","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"working_day":{"id":"60","label":"Working Day","alias":"working_day","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"problems":{"id":"61","label":"Problems","alias":"problems","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"goal":{"id":"62","label":"Goal","alias":"goal","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"gender":{"id":"63","label":"Gender","alias":"gender","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"age_category":{"id":"64","label":"Age Category","alias":"age_category","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"desired_weight":{"id":"65","label":"Desired Weight","alias":"desired_weight","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"unsubscribe_reason":{"id":"66","label":"Unsubscribe Reason","alias":"unsubscribe_reason","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_registration_date":{"id":"67","label":"Webinar Registration Date+Time","alias":"webinar_registration_date","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_day":{"id":"68","label":"Webinar Day","alias":"webinar_day","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_date":{"id":"69","label":"Webinar Date","alias":"webinar_date","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_expiration_day":{"id":"70","label":"Webinar Expiration Day","alias":"webinar_expiration_day","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_expiration_date":{"id":"71","label":"Webinar Expiration Date","alias":"webinar_expiration_date","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_time":{"id":"72","label":"Webinar Time","alias":"webinar_time","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_timezone":{"id":"73","label":"Webinar TimeZone","alias":"webinar_timezone","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_thank_you_url":{"id":"74","label":"Webinar Thank You URL","alias":"webinar_thank_you_url","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_live_room_url":{"id":"75","label":"Webinar Live Room URL","alias":"webinar_live_room_url","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_replay_room_url":{"id":"76","label":"Webinar Replay Room URL","alias":"webinar_replay_room_url","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"todays_date":{"id":"78","label":"Today's Date","alias":"todays_date","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"office_hours":{"id":"79","label":"Office Hours","alias":"office_hours","type":"number","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_date_datefield":{"id":"81","label":"Webinar Date (datefield)","alias":"webinar_date_datefield","type":"date","group":"core","object":"lead","is_fixed":"0","value":null}},"social":[],"personal":[],"professional":[]},"hasEditAccess":true,"custom":[{"attr":{"data-toggle":"ajaxmodal","data-target":"#MauticSharedModal","data-header":"Send a custom email to miekearendse26@gmail.com","href":"/mtc/s/contacts/email/200?list=1"},"btnText":"mautic.lead.email.send_email","iconClass":"fa fa-send"}],"columsAliases":null} []

LINE 4
[2019-07-28 14:54:36] mautic.WARNING: PHP Warning - Invalid argument supplied for foreach() - in file /var/www/clients/client2/web13/web/mtc/app/bundles/LeadBundle/Views/Lead/list_rows.html.php - at line 69 {"mauticTemplateVars":{"app":"[object] (Symfony\\Bundle\\FrameworkBundle\\Templating\\GlobalVariables: {})","items":{"200":"[object] (Mautic\\LeadBundle\\Entity\\Lead: Mautic\\LeadBundle\\Entity\\Lead with ID #200)"},"noContactList":[],"permissions":{"lead:leads:viewown":true,"lead:leads:viewother":true,"lead:leads:create":true,"lead:leads:editown":true,"lead:leads:editother":true,"lead:leads:deleteown":true,"lead:leads:deleteother":true},"security":"[object] (Mautic\\CoreBundle\\Security\\Permissions\\CorePermissions: {})","highlight":true,"mauticTemplate":"MauticLeadBundle:Lead:list_rows.html.php","view":"[object] (Mautic\\CoreBundle\\Templating\\Engine\\PhpEngine: {})"},"app":"[object] (Symfony\\Bundle\\FrameworkBundle\\Templating\\GlobalVariables: {})","items":{"200":"[object] (Mautic\\LeadBundle\\Entity\\Lead: Mautic\\LeadBundle\\Entity\\Lead with ID #200)"},"noContactList":[],"permissions":{"lead:leads:viewown":true,"lead:leads:viewother":true,"lead:leads:create":true,"lead:leads:editown":true,"lead:leads:editother":true,"lead:leads:deleteown":true,"lead:leads:deleteother":true},"security":"[object] (Mautic\\CoreBundle\\Security\\Permissions\\CorePermissions: {})","highlight":true,"mauticTemplate":"MauticLeadBundle:Lead:list_rows.html.php","view":"[object] (Mautic\\CoreBundle\\Templating\\Engine\\PhpEngine: {})","item":"[object] (Mautic\\LeadBundle\\Entity\\Lead: Mautic\\LeadBundle\\Entity\\Lead with ID #200)","fields":{"core":{"last_active":{"id":"19","label":"Date Last Active","alias":"last_active","type":"datetime","group":"core","object":"lead","is_fixed":"1","value":null},"firstname":{"id":"2","label":"First Name","alias":"firstname","type":"text","group":"core","object":"lead","is_fixed":"1","value":"Mieke"},"email":{"id":"6","label":"Email","alias":"email","type":"email","group":"core","object":"lead","is_fixed":"1","value":"miekearendse26@gmail.com"},"phone":{"id":"8","label":"Phone","alias":"phone","type":"tel","group":"core","object":"lead","is_fixed":"1","value":null},"timezone":{"id":"18","label":"mautic.lead.field.timezone","alias":"timezone","type":"timezone","group":"core","object":"lead","is_fixed":"1","value":null},"fb_form_id":{"id":"45","label":"FB Form ID","alias":"fb_form_id","type":"text","group":"core","object":"lead","is_fixed":"0","value":"917289431982736"},"fb_campaign_name":{"id":"46","label":"FB Campaign Name","alias":"fb_campaign_name","type":"text","group":"core","object":"lead","is_fixed":"0","value":"HypnoSlank - Webinar - Lead Ads 1"},"fb_campaign_id":{"id":"47","label":"FB Campaign ID","alias":"fb_campaign_id","type":"text","group":"core","object":"lead","is_fixed":"0","value":"23843291186700180"},"fb_adset_name":{"id":"48","label":"FB Adset Name","alias":"fb_adset_name","type":"text","group":"core","object":"lead","is_fixed":"0","value":"Targeting - 27/6 - A (micro adjustment 1)"},"fb_adset_id":{"id":"49","label":"FB Adset ID","alias":"fb_adset_id","type":"text","group":"core","object":"lead","is_fixed":"0","value":"23843483158650180"},"fb_ad_name":{"id":"50","label":"FB Ad Name","alias":"fb_ad_name","type":"text","group":"core","object":"lead","is_fixed":"0","value":"Trancewerk - Webinar (ED) Lead generation"},"fb_ad_id":{"id":"51","label":"FB Ad ID","alias":"fb_ad_id","type":"text","group":"core","object":"lead","is_fixed":"0","value":"23843483158660180"},"last_ordered_skus":{"id":"52","label":"Last Ordered SKUs","alias":"last_ordered_skus","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"all_ordered_skus":{"id":"53","label":"All Ordered SKUs","alias":"all_ordered_skus","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"last_order_number":{"id":"54","label":"Last Order Number","alias":"last_order_number","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"last_ordered_products":{"id":"55","label":"Last Ordered Products","alias":"last_ordered_products","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"last_used_payment_method":{"id":"56","label":"Last Used Payment Method","alias":"last_used_payment_method","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"last_order_status":{"id":"57","label":"Last Order Status","alias":"last_order_status","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"abandoned_cart_skus":{"id":"58","label":"Abandoned Cart SKUs","alias":"abandoned_cart_skus","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"working_day":{"id":"60","label":"Working Day","alias":"working_day","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"problems":{"id":"61","label":"Problems","alias":"problems","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"goal":{"id":"62","label":"Goal","alias":"goal","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"gender":{"id":"63","label":"Gender","alias":"gender","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"age_category":{"id":"64","label":"Age Category","alias":"age_category","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"desired_weight":{"id":"65","label":"Desired Weight","alias":"desired_weight","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"unsubscribe_reason":{"id":"66","label":"Unsubscribe Reason","alias":"unsubscribe_reason","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_registration_date":{"id":"67","label":"Webinar Registration Date+Time","alias":"webinar_registration_date","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_day":{"id":"68","label":"Webinar Day","alias":"webinar_day","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_date":{"id":"69","label":"Webinar Date","alias":"webinar_date","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_expiration_day":{"id":"70","label":"Webinar Expiration Day","alias":"webinar_expiration_day","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_expiration_date":{"id":"71","label":"Webinar Expiration Date","alias":"webinar_expiration_date","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_time":{"id":"72","label":"Webinar Time","alias":"webinar_time","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_timezone":{"id":"73","label":"Webinar TimeZone","alias":"webinar_timezone","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_thank_you_url":{"id":"74","label":"Webinar Thank You URL","alias":"webinar_thank_you_url","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_live_room_url":{"id":"75","label":"Webinar Live Room URL","alias":"webinar_live_room_url","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_replay_room_url":{"id":"76","label":"Webinar Replay Room URL","alias":"webinar_replay_room_url","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"todays_date":{"id":"78","label":"Today's Date","alias":"todays_date","type":"text","group":"core","object":"lead","is_fixed":"0","value":null},"office_hours":{"id":"79","label":"Office Hours","alias":"office_hours","type":"number","group":"core","object":"lead","is_fixed":"0","value":null},"webinar_date_datefield":{"id":"81","label":"Webinar Date (datefield)","alias":"webinar_date_datefield","type":"date","group":"core","object":"lead","is_fixed":"0","value":null}},"social":[],"personal":[],"professional":[]},"hasEditAccess":true,"custom":[{"attr":{"data-toggle":"ajaxmodal","data-target":"#MauticSharedModal","data-header":"Send a custom email to miekearendse26@gmail.com","href":"/mtc/s/contacts/email/200?list=1"},"btnText":"mautic.lead.email.send_email","iconClass":"fa fa-send"}],"columsAliases":null} []

Loading

@kuzmany
Copy link
Member Author

@kuzmany kuzmany commented Jul 29, 2019

@MauriceW2 I can't reproduce? How did you apply this patch? Did you clear cache? What isntance? (Mauticbox or your local?)

Loading

@MauriceW2
Copy link

@MauriceW2 MauriceW2 commented Jul 29, 2019

@kuzmany I tested it both in Mauticbox and local. On my local instance, I applied the patch manually by replacing and adding the files.

Let's be clear: the patch works fine! It's just that I got these entries in the logging. Of course I cleared the cache.

The weird thing is that it is happening inconsistently. Yesterday I had these entries. Today not yet. I will keep an eye on it here.

Loading

@kuzmany
Copy link
Member Author

@kuzmany kuzmany commented Jul 29, 2019

@MauriceW2 OK, I will test it again. Thanks

Loading

@MND13
Copy link

@MND13 MND13 commented Aug 7, 2019

I recently updated mautic from v2.7.1 to v2.15.1, why dont I see this in the Configurations > Contact settings ? I can only see Import Settings. Can anyone help how to add this?

Loading

@kuzmany
Copy link
Member Author

@kuzmany kuzmany commented Aug 8, 2019

@MND13 release 2.15.1 and 2.15.2 is just bug fix release. This feature need more attention to test and it's ready to test for next feature 2.16 release.

Loading

@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Aug 15, 2019
Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) Oct 17, 2019
Copy link
Member

@RCheesley RCheesley left a comment

Confirmed working without any errors in the log - great feature which will be super helpful for users!

Loading

@mautic mautic deleted a comment from mautibot Oct 17, 2019
@engerim42
Copy link

@engerim42 engerim42 commented Nov 3, 2019

One bug, only works if the field group is set to "Core". If I set a custom field to "Social" the column is shown but not the data.

Problems is in "app/bundles/LeadBundle/Views/Lead/row/default.html.php":

 if (isset($fields['core'][$column]['value'])) {
        echo $view->escape($fields['core'][$column]['value']);
    }

Dirty fix, just add below that:

if (isset($fields['social'][$column]['value'])) {
        echo $view->escape($fields['social'][$column]['value']);
    }

Loading

Mautic 2 automation moved this from Ready to Test (first time) to Changes Requested / Review Nov 5, 2019
@kuzmany
Copy link
Member Author

@kuzmany kuzmany commented Nov 5, 2019

@engerim42 Thanks. Good catch. Fixed

Loading

@npracht npracht removed this from the 2.16.0 milestone Jan 23, 2020
@RCheesley
Copy link
Member

@RCheesley RCheesley commented Aug 17, 2020

@Wise-Gorilla we also do not have two tests on Mautic 3 or a code coverage report, so we would need those before it could be considered.

Loading

@RCheesley
Copy link
Member

@RCheesley RCheesley commented Aug 28, 2020

@cla-bot check

Loading

@cla-bot cla-bot bot added the cla-signed label Aug 28, 2020
@cla-bot
Copy link

@cla-bot cla-bot bot commented Aug 28, 2020

The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings!

Loading

@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Sep 30, 2020

Travis tests have failed

Hey @kuzmany,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 48cecac0-02ff-11eb-8abf-036a378110f7

Loading

@kuzmany
Copy link
Member Author

@kuzmany kuzmany commented Nov 12, 2020

Conflicts resolved.
We use this on production for all clients long time without any issue.

Loading

@codecov
Copy link

@codecov codecov bot commented Nov 12, 2020

Codecov Report

Merging #7511 (999c184) into staging (35c44b0) will increase coverage by 0.00%.
The diff coverage is 34.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             staging    #7511   +/-   ##
==========================================
  Coverage      31.55%   31.55%           
- Complexity     33739    33751   +12     
==========================================
  Files           1966     1968    +2     
  Lines         116985   117061   +76     
==========================================
+ Hits           36913    36939   +26     
- Misses         80072    80122   +50     
Impacted Files Coverage Δ Complexity Δ
app/bundles/LeadBundle/Form/Type/ConfigType.php 0.00% <0.00%> (ø) 5.00 <0.00> (+3.00)
...undles/LeadBundle/Form/Type/ContactColumnsType.php 0.00% <0.00%> (ø) 3.00 <3.00> (?)
...p/bundles/LeadBundle/Controller/LeadController.php 27.02% <100.00%> (+0.08%) 177.00 <0.00> (ø)
...s/LeadBundle/Services/ContactColumnsDictionary.php 100.00% <100.00%> (ø) 6.00 <6.00> (?)

Loading

lijupm
lijupm approved these changes Nov 20, 2020
Copy link
Contributor

@lijupm lijupm left a comment

Verified OK. Functionality is working as expected.

Awesome work. Code looks good too! 👍

Loading

Copy link
Member

@RCheesley RCheesley left a comment

Tested with core, social and custom fields - works great, able to sort and reverse sort.

Please can we have a simple PR to the docs to tell people about this feature? Can be done post-merge. Pinging @mautic/education-team for follow up if necessary.

Loading

@mautibot
Copy link

@mautibot mautibot commented Dec 1, 2020

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/mautic-3-2-growing-together/17244/1

Loading

@namratasaun
Copy link

@namratasaun namratasaun commented Dec 4, 2020

I can't find this in 2.15.3 in contact settings

Loading

@kuzmany
Copy link
Member Author

@kuzmany kuzmany commented Dec 4, 2020

@namratasaun It was added to 3.2.0

Loading

@namratasaun
Copy link

@namratasaun namratasaun commented Dec 4, 2020

@namratasaun It was added to 3.2.0

oh, ok! thanks a lot. any workaround for previous versions? I want to show phone number in the contacts list.

Loading

@RCheesley
Copy link
Member

@RCheesley RCheesley commented Dec 4, 2020

any workaround for previous versions?

No, we no longer support 2.x!

Loading

@namratasaun
Copy link

@namratasaun namratasaun commented Dec 4, 2020

any workaround for previous versions?

No, we no longer support 2.x!

oh alright, thanks a lot

Loading

@biggala2310
Copy link

@biggala2310 biggala2310 commented Mar 23, 2021

Hello, I noticed that the Contact Owner field is not available for selection in the column list.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment