Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LightSAML vendors and fix bug in uploading files through Configuration #7512

Open
wants to merge 2 commits into
base: staging
from

Conversation

Projects
None yet
1 participant
@alanhartless
Copy link
Contributor

commented May 10, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? y
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This updates lightSAML to the latest versions. It also fixes a bug in Mautic's Configuration when a file is uploaded, such as a SAML metadata file, that caused an exception.

Steps to reproduce the bug:

  1. Upload an XML file (even if fake) through the Identity Provider Metadata file under User/Authentication tab of the configuration and save the Configuration.
  2. Notice that the configuration page will error.

Steps to test this PR:

  1. Load up this PR
  2. Retest file uploads and the configuration should save without an error
  3. Test a SAML implementation (https://www.mautic.org/docs/en/authentication/saml.html; I personally tested using SF as an identify provider https://help.salesforce.com/articleView?id=identity_provider_enable.htm&type=5). If using Salesforce, configure the SAML Email attribute to be "Username", First name = "FirstName" and Last name = "LastName")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.