Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve boolean import/API support #7513

Open
wants to merge 3 commits into
base: staging
from

Conversation

Projects
None yet
2 participants
@heathdutton
Copy link
Member

commented May 10, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature? Y
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks? N
Deprecations?

Description:

When creating leads by imports or APIs, boolean values that don't use "true" or "false" (etc) end up being stored as FALSE, instead of NULL (a more accurate value for a non-answer). This can cause a lot of confusion. This fixes that and also supports values like "T" and "F" which are obviously representative.

Steps to reproduce the bug:

  1. Create a boolean field.
  2. Import a CSV with one lead value of "T".
  3. Open the lead imported and you'll see "No" (false value) selected.

Steps to test this PR:

  1. Load up this PR
  2. Create a boolean field.
  3. Import a CSV with one lead value of "T".
  4. Open the lead imported and you'll see "Yes" (true value) selected.

heathdutton added some commits Dec 10, 2018

Improve boolean field accuracy.
Invalid values being imported will not be saved as FALSE by default,
but will be treated as NULL (a non answer). T,F,Y,N values are also
supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.