Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic content slot duplication errors inside builder #7536

Merged

Conversation

@Enc3phale
Copy link
Contributor

commented May 16, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? N
Automated tests included? N
Related user documentation PR URL N
Related developer documentation PR URL N
Issues addressed (#s or URLs) N
BC breaks? N
Deprecations? N

Description:

In the builder when you clone a dynamic content slot, this slot is duplicated with the same identifier.
This produces bugs like when you edit one, the second is also modified or when you delete one the second is no more editable.

Warning: no more errors when duplicated but content is not duplicated, it's reset by default.

Steps to reproduce the bug:

  1. Make a new mail
  2. Open the builder
  3. Create a dynamic content slot and put a content
  4. Duplicate this slot
  5. Edit the new slot
  6. See that the first slot is also modified

Steps to test this PR:

  1. Load up this PR
  2. Repeat step above
  3. The first slot is no more modified
Copy link
Member

left a comment

Works properly.

@npracht npracht added this to the 2.16.0 milestone May 17, 2019
@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Aug 15, 2019
Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) Aug 17, 2019
@Woeler
Woeler approved these changes Aug 17, 2019
@Woeler Woeler merged commit c0ad475 into mautic:staging Aug 17, 2019
2 checks passed
2 checks passed
Scrutinizer Analysis: 1 new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Mautic 2 automation moved this from Ready to Test (first time) to Merged Aug 17, 2019
@Woeler Woeler modified the milestones: 2.16.0, 2.15.3 Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mautic 2
  
Merged
3 participants
You can’t perform that action at this time.