Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.15.2 beta #7580

Merged
merged 300 commits into from Jun 3, 2019

Conversation

Projects
None yet
@kuzmany
Copy link
Contributor

commented Jun 3, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Steps to reproduce the bug:

Steps to test this PR:

  1. Load up this PR

List deprecations along with the new alternative:

List backwards compatibility breaks:

escopecz and others added some commits Jan 31, 2019

Revert "overwrite empty values"
This reverts commit 3bf2ce4.

kuzmany and others added some commits May 19, 2019

7250: Fix for Email to Contact API request with assets (reference to … (
#7332)

7250: Fix for Email to Contact API request with assets (reference to …
Custom field with type text requires string shorter than 256 chars (#…
…7283)

Custom field with type text requires string shorter than 256 chars
Handle aggregator fields on subscribed (emailed) reports. (#7266)
Handle aggregator fields on subscribed (emailed) reports.
Fix Sugar/Suite CRM sync for email addresses with an uppercase char (#…
…7401)

Fix Sugar/Suite CRM sync for email addresses with an uppercase char
Duplicated leads are created by Salesforce sync (#7463)
Duplicated leads are created by Salesforce sync
Prevent an exception when a contact is deleted between the time logs … (
#7443)

Prevent an exception when a contact is deleted between the time logs …
Fix issue with tooltip getting frozen in campaign UI and fix issue wh…
…ere campaign events were rescheduled in UTC rather than the configured hour (#7448)

Fix issue with tooltip getting frozen in campaign UI and fix issue where campaign events were rescheduled in UTC rather than the configured hour
Prevents an exception for DWC and focus requests that aren't tracked (#…
…7197)

Prevents an exception for DWC and focus requests that aren't tracked
Prevent exceptions if a campaign jump target is removed. (#7364)
Prevent exceptions if a campaign jump target is removed.
Fix autofill boolean fields (#7347)
Fix autofill boolean fields
Allow HTML in signature by user API (#7543)
Allow HTML in signature by user API
Merge pull request #7110 from KalleVuorjoki/staging
Multiple value on List-Unsubscribe header
Fix Warning: Illegal offset type with m:s:u command (#6706)
Fix Warning: Illegal offset type with m:s:u command
Merge pull request #7358 from mautic/hotfix.lead-repository-parameter…
…-binding

Bugfix: Bind each search value as its own parameter in the query builder
Reject page_hit queue messages without a Hit
In consuming a page_hit queue, it is possible to encounter a message
which does not contain a valid 'hitId' (e.g. NULL). Since the
signature of the PageModel#processPageHit method requires the $hit
argument to be an instance of Hit, an exception will be thrown when no
entity is found by the HitRepository.

A null value for $hit is handled herein by simply setting the event to
REJECT that message. This will result in a loss of data, which may or
may not be a problem for some users. Should retention of that data be
desired, one should probably register an event listener of their own
to do something with rejected message payloads.
Add unit tests for PageSubscriber::onPageHit
Two tests to verify event result under different scenarios:

  - testOnPageHit_WhenCalled_AcknowledgesHit: when a payload contains
    a 'hitId' which resolves to a Hit entity, the PageModel will
    process the hit and set the event result to
    QueueConsumerResults::ACKNOWLEDGE.

  - testOnPageHit_WhenCalled_RejectsBadHit: when a payload does not
    contain a 'hitId' or no corresponding Hit entity can be found, the
    onPageHit method returns early after setting the event result to
    QueueConsumerResults::REJECT.
Reject erroneous page_hit queue messages (#6983)
Reject erroneous page_hit queue messages
Prevent an issue with installation and Mautibox for installations in …
…subdirectories (#7572)

Prevent an issue with installation and Mautibox for installations in subdirectories

@kuzmany kuzmany merged commit de99722 into master Jun 3, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.