Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add segment filter to various reports #7585

Open
wants to merge 5 commits into
base: staging
from

Conversation

Projects
None yet
2 participants
@kuzmany
Copy link
Contributor

commented Jun 4, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR added segment filter to several reports type:

  • assets download
  • email stats
  • form submission
  • page hits
  • video hits

Steps to test this PR:

  1. Load up this PR
  2. Create item related to some contact for each entities above
  3. Then test segment filter for each entities report.

image

@kuzmany kuzmany added this to the 2.16.0 milestone Jun 4, 2019

kuzmany added some commits Jun 4, 2019

@aymericfrancois

This comment has been minimized.

Copy link

commented Jun 5, 2019

Tested this PR. Everything works except the "E-mail sent" report.

How to reproduce :

  1. Create two contacts "One" and "Two".
  2. Create a segment "Segment A" and add contacts "One" and "Two" in it.
  3. Create a segment "Segment B" and add contact "One" in it.
  4. Create a "Segment Email" and send it to the segment "Segment A".
  5. Create a report with "Email sent" data source.
  6. In data, add : "ID" and "Contact email"
  7. In filters, add "Segment" equals "Segment B".
  8. Save and close.

Then, this happens.

2019-06-05_10h44_11

kuzmany added some commits Jun 5, 2019

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

@aymericfrancois fixed. Please re-test

@aymericfrancois

This comment has been minimized.

Copy link

commented Jun 6, 2019

Works perfectly ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.