Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tracking 404 #7614

Open
wants to merge 8 commits into
base: staging
from

Conversation

Projects
None yet
4 participants
@kuzmany
Copy link
Contributor

commented Jun 17, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #7565
BC breaks?
Deprecations?

Description:

Based on discussion #7565 and comment #7565 (comment)
we've added option disable 404 error page tracking for anonymous visitors. This causes a lot of anonymous contacts from bots. New option added to Configuration > Tracking Settings tab. UNIT test included in this PR

Steps to reproduce the bug:

  1. Try in incognito not existed url: https://yourmautic.com/whatever
  2. Go to Mautic > Contacts and switch to anonymous list view
  3. See new contact was create with https://yourmautic.com/whatever page hit

Steps to test this PR:

  1. Load up this PR
  2. Repeat all steps
  3. See If 404 not found page wasn't tracked
  4. Create identified contact (via form, via tracking code)
  5. Go to 404 not found page and see If page was tracked

image

@kuzmany kuzmany added this to the 2.16.0 milestone Jun 17, 2019

@aspiers
Copy link

left a comment

Hi, thanks a lot for doing this!! It looks great but it's not clear to me whether the option disables tracking of all 404s, or just anonymous 404s? As explained in #7565 (comment) it is important that 404s generated by known contacts are still tracked, even when the option is enabled.

@mightyfree
Copy link

left a comment

Requesting changes to en_US entries for improved grammar, punctuation.

Update app/bundles/PageBundle/Translations/en_US/messages.ini
Co-Authored-By: Lance M. <mightyfree@users.noreply.github.com>
Update app/bundles/PageBundle/Translations/en_US/messages.ini
Co-Authored-By: Lance M. <mightyfree@users.noreply.github.com>
@kuzmany

This comment has been minimized.

Copy link
Contributor Author

commented Jun 25, 2019

@mightyfree thank you

@aspiers at the moment, client did pay just for this feature.
I agree with your suggestion, but there is no budget for extra hours. If you are interest let me now and I can extend it.

@indorock

This comment has been minimized.

Copy link

commented Jun 28, 2019

@mightyfree thank you

@aspiers at the moment, client did pay just for this feature.
I agree with your suggestion, but there is no budget for extra hours. If you are interest let me now and I can extend it.

@kuzmany how much more time do you estimate you'll need to add that extra change?

kuzmany added some commits Jul 10, 2019

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

commented Jul 13, 2019

thanks to @indorock donate
I've added support for disable tracking 404 page for anonymous contacts
PR, description and steps to reproduce/tests was updated.

Please re-test @aspiers @indorock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.