Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Salesforce boolean sync and fix warning #7643

Merged
merged 2 commits into from Aug 17, 2019

Conversation

@Enc3phale
Copy link
Contributor

commented Jun 25, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? N
Automated tests included? N
Related user documentation PR URL N
Related developer documentation PR URL N
Issues addressed (#s or URLs) N
BC breaks? N
Deprecations? N

Description:

Boolean field is not synchronized properly.

Fix some warning like:

[2019-06-11 11:54:48] mautic.NOTICE: PHP Notice - Undefined index: create - in file /plugins/MauticCrmBundle/Integration/SalesforceIntegration.php - at line 717 [] []
[2019-06-11 11:54:49] mautic.NOTICE: PHP Notice - Undefined index: create - in file /plugins/MauticCrmBundle/Integration/SalesforceIntegration.php - at line 760 [] []
[2019-06-11 11:54:49] mautic.CRITICAL: Uncaught PHP Exception Symfony\Component\Debug\Exception\FatalThrowableError: "Type error: Argument 1 passed to MauticPlugin\MauticCrmBundle\Api\SalesforceApi::createLead() must be of the type array, null given, called in /plugins/MauticCrmBundle/Integration/SalesforceIntegration.php on line 760" at /plugins/MauticCrmBundle/Api/SalesforceApi.php line 185 {"exception":"[object] (Symfony\\Component\\Debug\\Exception\\FatalThrowableError(code: 0): Type error: Argument 1 passed to MauticPlugin\\MauticCrmBundle\\Api\\SalesforceApi::createLead() must be of the type array, null given, called in /plugins/MauticCrmBundle/Integration/SalesforceIntegration.php on line 760 at /plugins/MauticCrmBundle/Api/SalesforceApi.php:185)"} []

Steps to reproduce the bug:

  1. Install and configure Salesforce
  2. Map boolean field for Contact
  3. Set one Salesforce boolean value to true
  4. Launch command to sync php app/console mautic:integration:fetchleads --time-interval=180minutes --integration=Salesforce
  5. Set Salesforce boolean value to false
  6. Relaunch sync
  7. Value of this boolean field is stuck on true on Mautic side.

Steps to test this PR:

  1. Load up this PR
  2. Repeat step above
  3. On the second sync, value is now false on Mautic side.
Copy link
Member

left a comment

Tested in production environment

@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Aug 15, 2019
Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) Aug 17, 2019
@Woeler
Woeler approved these changes Aug 17, 2019
@Woeler Woeler merged commit e1e8b3e into mautic:staging Aug 17, 2019
2 checks passed
2 checks passed
Scrutinizer Analysis: 3 new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Mautic 2 automation moved this from Ready to Test (first time) to Merged Aug 17, 2019
@Woeler Woeler modified the milestones: 2.16.0, 2.15.3 Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mautic 2
  
Merged
3 participants
You can’t perform that action at this time.