Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zoho contact sync #7644

Merged
merged 2 commits into from Aug 17, 2019

Conversation

@Enc3phale
Copy link
Contributor

commented Jun 25, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? Y
Automated tests included? N
Related user documentation PR URL N
Related developer documentation PR URL N
Issues addressed (#s or URLs) N
BC breaks? N
Deprecations? N

Description:

Add boolean field to Zoho sync.
Add company mapping to contact.
Fix sync for Contact.
Fix some warning like:

[2019-05-28 09:26:34] mautic.NOTICE: Doctrine\ORM\EntityNotFoundException: Entity of type 'Mautic\PluginBundle\Entity\IntegrationEntity' for IDs id(66) was not found (uncaught exception) at /vendor/doctrine/orm/lib/Doctrine/ORM/EntityNotFoundException.php line 47 while running console command `mautic:integration:fetchleads` [] []

Steps to reproduce the bug:

  1. Install and configure Zoho
  2. Map Company field, Lead field and Contact field
  3. See that there is no Boolean in mapping
  4. Launch command to sync php app/console mautic:integration:fetchleads --time-interval=180minutes --integration=Zoho
  5. See that Zoho contact haves no company inside Mautic
  6. See that there is some warning inside log.

Steps to test this PR:

  1. Load up this PR
  2. Repeat step above
  3. Everything works as expected
Copy link
Member

left a comment

Tested in production environment

@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Aug 15, 2019
Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) Aug 17, 2019
@Woeler
Woeler approved these changes Aug 17, 2019
@Woeler Woeler merged commit 4e27d03 into mautic:staging Aug 17, 2019
2 checks passed
2 checks passed
Scrutinizer Analysis: 2 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Mautic 2 automation moved this from Ready to Test (first time) to Merged Aug 17, 2019
@Woeler Woeler modified the milestones: 2.16.0, 2.15.3 Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mautic 2
  
Merged
3 participants
You can’t perform that action at this time.