Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5145: Check that `cURL` is installed. #7657

Merged
merged 1 commit into from Aug 17, 2019

Conversation

@Aerendir
Copy link
Contributor

commented Jun 29, 2019

Q A
Bug fix? Yes
New feature? No
Automated tests included? No
Related user documentation PR URL No
Related developer documentation PR URL No
Issues addressed (#s or URLs) #5145
BC breaks? No
Deprecations? No

Description:

This PR adds a check to ensure the cURL extension is loaded on the server as it is required by Mautic to work.

Steps to reproduce the bug:

  1. Disable the cURL extension on your server
  2. Install Mautic: the installer doesn't alert you the extension isn't loaded
  3. Complete the installation
  4. Login: a 500 error appears

Uh oh! I think I broke it. If I do it again, please report me to the system administrator!

[Fri Jun 28 18:00:01.517917 2019] [php7:warn] [pid 7822] [client 93.151.244.14:62594] PHP Warning:  Use of undefined constant CURLOPT_FOLLOWLOCATION - assumed 'CURLOPT_FOLLOWLOCATION' (this will throw an Error in a future version of PHP) in /var/www/mautic/public_html/app/bundles/PluginBundle/Integration/AbstractIntegration.php on line 1023, referer: https://mautic/s/plugins
[Fri Jun 28 18:00:01.517943 2019] [php7:warn] [pid 7822] [client 93.151.244.14:62594] PHP Warning:  Use of undefined constant CURLOPT_REFERER - assumed 'CURLOPT_REFERER' (this will throw an Error in a future version of PHP) in /var/www/mautic/public_html/app/bundles/PluginBundle/Integration/AbstractIntegration.php on line 1024, referer: https://mautic/s/plugins
[Fri Jun 28 18:00:01.517972 2019] [php7:warn] [pid 7822] [client 93.151.244.14:62594] PHP Warning:  Use of undefined constant CURLOPT_USERAGENT - assumed 'CURLOPT_USERAGENT' (this will throw an Error in a future version of PHP) in /var/www/mautic/public_html/app/bundles/PluginBundle/Integration/AbstractIntegration.php on line 1025, referer: https://mautic/s/plugins
[Fri Jun 28 18:01:06.442964 2019] [php7:warn] [pid 7689] [client 93.151.244.14:62605] PHP Warning:  Use of undefined constant CURLOPT_HTTP_VERSION - assumed 'CURLOPT_HTTP_VERSION' (this will throw an Error in a future version of PHP) in /var/www/mautic/public_html/app/bundles/PluginBundle/Integration/AbstractIntegration.php on line 1020, referer: https://mautic/s/plugins
[Fri Jun 28 18:01:06.443029 2019] [php7:warn] [pid 7689] [client 93.151.244.14:62605] PHP Warning:  Use of undefined constant CURL_HTTP_VERSION_1_1 - assumed 'CURL_HTTP_VERSION_1_1' (this will throw an Error in a future version of PHP) in /var/www/mautic/public_html/app/bundles/PluginBundle/Integration/AbstractIntegration.php on line 1020, referer: https://mautic/s/plugins
[Fri Jun 28 18:01:06.443062 2019] [php7:warn] [pid 7689] [client 93.151.244.14:62605] PHP Warning:  Use of undefined constant CURLOPT_HEADER - assumed 'CURLOPT_HEADER' (this will throw an Error in a future version of PHP) in /var/www/mautic/public_html/app/bundles/PluginBundle/Integration/AbstractIntegration.php on line 1021, referer: https://mautic/s/plugins
[Fri Jun 28 18:01:06.443095 2019] [php7:warn] [pid 7689] [client 93.151.244.14:62605] PHP Warning:  Use of undefined constant CURLOPT_RETURNTRANSFER - assumed 'CURLOPT_RETURNTRANSFER' (this will throw an Error in a future version of PHP) in /var/www/mautic/public_html/app/bundles/PluginBundle/Integration/AbstractIntegration.php on line 1022, referer: https://mautic/s/plugins
[Fri Jun 28 18:01:06.443122 2019] [php7:warn] [pid 7689] [client 93.151.244.14:62605] PHP Warning:  Use of undefined constant CURLOPT_FOLLOWLOCATION - assumed 'CURLOPT_FOLLOWLOCATION' (this will throw an Error in a future version of PHP) in /var/www/mautic/public_html/app/bundles/PluginBundle/Integration/AbstractIntegration.php on line 1023, referer: https://mautic/s/plugins
[Fri Jun 28 18:01:06.443149 2019] [php7:warn] [pid 7689] [client 93.151.244.14:62605] PHP Warning:  Use of undefined constant CURLOPT_REFERER - assumed 'CURLOPT_REFERER' (this will throw an Error in a future version of PHP) in /var/www/mautic/public_html/app/bundles/PluginBundle/Integration/AbstractIntegration.php on line 1024, referer: https://mautic/s/plugins
[Fri Jun 28 18:01:06.443177 2019] [php7:warn] [pid 7689] [client 93.151.244.14:62605] PHP Warning:  Use of undefined constant CURLOPT_USERAGENT - assumed 'CURLOPT_USERAGENT' (this will throw an Error in a future version of PHP) in /var/www/mautic/public_html/app/bundles/PluginBundle/Integration/AbstractIntegration.php on line 1025, referer: https://mautic/s/plugins

Steps to test this PR:

  1. Load up this PR

Not so involved in the project to know how to use this

@Aerendir Aerendir changed the title Fix #5145: Check that `cURL` is installed. Fix https://github.com/mautic/mautic/issues/5145: Check that `cURL` is installed. Jun 29, 2019
@Aerendir Aerendir changed the title Fix https://github.com/mautic/mautic/issues/5145: Check that `cURL` is installed. Fix #5145: Check that `cURL` is installed. Jun 29, 2019
@escopecz escopecz added the Bug label Jul 1, 2019
@npracht npracht added this to the 2.16.0 milestone Aug 15, 2019
@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Aug 15, 2019
Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) Aug 17, 2019
@Woeler
Woeler approved these changes Aug 17, 2019
@Woeler Woeler merged commit 5c18db0 into mautic:staging Aug 17, 2019
2 checks passed
2 checks passed
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Mautic 2 automation moved this from Ready to Test (first time) to Merged Aug 17, 2019
@Aerendir Aerendir deleted the Aerendir:5145-check-curl-is-installed branch Aug 23, 2019
@Woeler Woeler modified the milestones: 2.16.0, 2.15.3 Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mautic 2
  
Merged
4 participants
You can’t perform that action at this time.