Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form custom attributes #7687

Merged
merged 2 commits into from Aug 17, 2019

Conversation

@kuzmany
Copy link
Contributor

commented Jul 15, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature? x
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Some software may require custom attributes for form tag (analytics etc).
This PR added custom attributes for form tag. Similar like we've already use custom attributes for fields.

image

Steps to test this PR:

  1. Load up this PR
  2. Create form and add Form attributes (new field )
  3. Check the source code of form and you should see custom attributes in form tag

image

@kuzmany kuzmany added this to the 2.16.0 milestone Jul 15, 2019

@npracht
Copy link
Member

left a comment

It works, but can you remove the red start saying it is mandatory:

  1. I tried without value and it is working (so the "mandatory" feature is not working on form validation)
  2. It shouldn't be mandatory.

Thanks

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

@npracht Removed required flag

@npracht
Copy link
Member

left a comment

👍

@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Aug 15, 2019

@Woeler

Woeler approved these changes Aug 17, 2019

Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) Aug 17, 2019

@Woeler Woeler merged commit 34bcbe7 into mautic:staging Aug 17, 2019

2 checks passed

Scrutinizer Analysis: 5 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Test (first time) to Merged Aug 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.