Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not submit emails validation #7709

Open
wants to merge 4 commits into
base: staging
from

Conversation

@kuzmany
Copy link
Contributor

commented Jul 25, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature? x
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

A coporation marketer requires do not submit form for certain emails. This PR added new Do Not Submit emails list to configuration and optional validation for this list
This feature is offered by Salesforce Pardot.

Steps to test this PR:

  1. Load up this PR
  2. Go to Configuration > Form Settings > Do not submit these emails
  • add email example@domain.tld (should blocked this email)
  • add domain with * (*@gmail.com) - should blocked all gmail emails
  1. Create form with email enable Do Not Submit validation. Also try customization of validation message
  2. Then try submit with emails
  3. Form should return error message

Screenshot

image

image

@kuzmany kuzmany added this to the 2.16.0 milestone Jul 25, 2019

@npracht

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

@escopecz funny thing, I've just received the newsletter of Mautic Inc. and your team proposes to follow this process: https://mautic.com/help/verifying-email-domains-on-form-submissions/?utm_source=july19newsletter&utm_medium=email
which is the same feature as the one of this PR. Can you kindly ask you marketing team to test the PR when finished ?

@npracht npracht self-requested a review Jul 25, 2019

@kuzmany kuzmany added Ready To Test and removed WIP labels Jul 25, 2019

@escopecz

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

Interesting. I believe that the goal is the same but that article describes how to implement a browser side validation without a need to modify Mautic. On the other hand this PR implements it on the server side.

@florentpetitjean
Copy link

left a comment

All is working as intended

@kuzmany kuzmany changed the title Do not submit emails filter Do not submit emails validation Jul 25, 2019

@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.