Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New post save api hook #7719

Merged
merged 9 commits into from Jan 28, 2020
Merged

Conversation

@escopecz
Copy link
Member

escopecz commented Jul 26, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? N
New feature? Enhancement
Automated tests included? N
Related user documentation PR URL /
Related developer documentation PR URL /
Issues addressed (#s or URLs) /
BC breaks? N
Deprecations? N

Description:

This hook will allow plugins to get the saved entity and the whole Request and do their stuff with it. It will allow them to send more data for example with the contact create request and connect those to the contact.

This also fixes one bug where API contact updates threw a lot of PHP notices as the field group all is artificially added to the field groups and has different array schema. So the changes in this PR ignores the all group.

Steps to test this PR:

  1. There is nothing to test as this is not adding any behavior change. Code review should suffice.
  2. If someone wants to ensure that API still works, do that.
alanhartless and others added 9 commits Mar 25, 2019
Release 2.15.2 beta
@escopecz escopecz added this to the 2.16.0 milestone Jul 26, 2019
@npracht npracht added this to Ready to Test (first time) in Mautic 2 Aug 15, 2019
Copy link
Contributor

kuzmany left a comment

Code looks OK.
I tested basic api call - works
Approve it 👍

@escopecz escopecz removed the Code Review label Aug 18, 2019
@npracht npracht moved this from Ready to Test (first time) to Ready to Commit (passed testing) in Mautic 2 Aug 19, 2019
@npracht npracht modified the milestone: 2.16.0 Jan 23, 2020
@dennisameling dennisameling merged commit 1c2dcbd into mautic:staging Jan 28, 2020
2 checks passed
2 checks passed
Scrutinizer Analysis: 1 new issues, 5 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mautic 2
  
Merged
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.