Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query to apply MySQL defaults to readme. #7727

Merged
merged 1 commit into from Aug 17, 2019

Conversation

@heathdutton
Copy link
Member

commented Jul 26, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #5328 #6471
BC breaks? N
Deprecations? N

Description:

sql_mode does not include "ONLY_FULL_GROUP_BY" by default in stock MySQL, but it causes various problems in Mautic if enabled as Mautic is not compatible with that strict convention. innodb_default_row_format is "dynamic" by default in MySQL 5.7+ but there is no downside to setting this early with ~5.6 as it allows a smoother upgrade path, performance benefits, and reduced index limitations. We could set these (at the session level) during installation/migration/plugin-update automatically in the future and remove the need to explain this.

sql_mode does not include "ONLY_FULL_GROUP_BY" by default in stock MySQL, but it causes various problems in Mautic if enabled as Mautic is not compatible with that strict convention. innodb_default_row_format is "dynamic" by default in MySQL 5.7+ but there is no downside to setting this early with ~5.6 as it allows a smoother upgrade path, performance benefits, and reduced index limitations. We could set these (at the session level) during installation/migration/plugin-update automatically in the future and remove the need to explain this. Re: #5328 #6471
@npracht npracht added this to the 2.16.0 milestone Jul 26, 2019
@npracht npracht added this to Ready to Commit (passed testing) in Mautic 2 Aug 15, 2019
@Woeler Woeler merged commit 36a8b04 into staging Aug 17, 2019
3 checks passed
3 checks passed
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged Aug 17, 2019
@Woeler Woeler deleted the mysql-reccomendations branch Aug 17, 2019
@Woeler Woeler modified the milestones: 2.16.0, 2.15.3 Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mautic 2
  
Merged
3 participants
You can’t perform that action at this time.