Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tags HTML-escaping #7741

Open
wants to merge 4 commits into
base: staging
from

Conversation

@kuzmany
Copy link
Contributor

commented Jul 30, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #6057
BC breaks?
Deprecations?

Description:

This fix is based on issues #6057
This PR fix HTML-escaping for tags

Steps to reproduce the bug:

  1. Create a tag with the tracking script with a special character and refresh page

    mt('send', 'pageview', { tags: ['-test"eee', 'test"fff' ]});

  2. Too much rows gets created in the database in lead_tags table

Steps to test this PR:

  1. Load up this PR
  2. Repeat all steps
  3. Should now work properly

@kuzmany kuzmany added this to the 2.16.0 milestone Jul 30, 2019

@florentpetitjean
Copy link

left a comment

Tags do not duplicate, but I can't see the first tag in my test instance > '-test"eee' . (tags use in your test process)

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

@florentpetitjean that symbol - mean remove tags. Then you can create it and with - remove it.

@florentpetitjean

This comment has been minimized.

Copy link

commented Jul 31, 2019

Oh ok didn't know that, thanks.
So it works well !

@florentpetitjean
Copy link

left a comment

Working as intended in test.

kuzmany added some commits Jul 31, 2019

@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.