Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix report empty expression #7746

Open
wants to merge 1 commit into
base: staging
from

Conversation

@kuzmany
Copy link
Contributor

commented Jul 31, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #7737
BC breaks?
Deprecations?

Description:

Report empty expression return wrong condition:

  • (column IS NULL AND column != '')

We expected

  • (columns IS NULL OR column !='')

Steps to reproduce the bug:

  1. Create contact without email
  2. Create contact report with filter empty email
    image
  3. See no results. We expected results

Steps to test this PR:

  1. Load up this PR
  2. Repeat all steps
  3. Empty filter should return results
@florentpetitjean
Copy link

left a comment

Works great !

@npracht npracht added this to Ready to Test (first time) in Mautic 2 Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.