Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix form boolean mapping #7782

Merged
merged 1 commit into from Aug 17, 2019

Conversation

@Enc3phale
Copy link
Contributor

commented Aug 13, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? N
Automated tests included? N
Related user documentation PR URL N
Related developer documentation PR URL N
Issues addressed (#s or URLs) N
BC breaks? N
Deprecations? N

Description:

Form submission don't set boolean mapped field when value = 0 for new contact.

Steps to reproduce the bug:

  1. Create a custom boolean field
  2. Create a form
  3. Add a radio group field with value 1 and 0, and map it to your custom field
  4. Add an email field
  5. Go to form and submit it with a new email and radio value = 0
  6. Go to the new created lead, see that boolean field is not set

Steps to test this PR:

  1. Load up this PR
  2. Repeat step above
  3. Boolean field is now correctly set
@Woeler
Woeler approved these changes Aug 14, 2019
@npracht npracht added this to the 2.16.0 milestone Aug 15, 2019
@npracht npracht added this to Ready to Commit (passed testing) in Mautic 2 Aug 15, 2019
Mautic 2 automation moved this from Ready to Commit (passed testing) to Ready to Test (first time) Aug 15, 2019
@Woeler Woeler moved this from Ready to Test (first time) to Ready to Commit (passed testing) in Mautic 2 Aug 17, 2019
@Woeler Woeler merged commit 9cbbf08 into mautic:staging Aug 17, 2019
2 checks passed
2 checks passed
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged Aug 17, 2019
@Woeler Woeler modified the milestones: 2.16.0, 2.15.3 Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mautic 2
  
Merged
3 participants
You can’t perform that action at this time.