Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMS enhacements #7795

Open
wants to merge 24 commits into
base: staging
from

Conversation

@kuzmany
Copy link
Contributor

commented Aug 14, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Notice for testers and developers

This PR continue work on PR #7449 it should be merged to staging before test this PR

Description:

#7449 bring support for text messages transport callback and receive info about reply.
This PR extend it with callback about deliveries info and stats (delivered, read, failed) or campaign decision (is delivered, is read, is failed).
This callback support process multiple results from webhook.

This can be used by any integration transport.

Every transport can define:

  • what callback data can receive (reply, delivered info...)
  • what kind of statistic would display (delivered, read, failed) based on TransportSettingsInterface
  • add properties to SMS - for example our transport can add device (phone number) to each sms and media file from provider servers (whatsapp)

Stats in sms list

image

Stats in detail

image

Custom SMS properties extend by plugin

image

Steps to test this PR:

  1. You can test Twilio. Should works like before. You can use Mautibox for test http://mautibox.com/7795
  2. Contact me, I'll send you custom Text message transports to test another features of PR

@kuzmany kuzmany added this to the 2.16.0 milestone Aug 14, 2019

@kuzmany kuzmany changed the title Add support for sms delivered, read or failed state Add support for sms delivered, read or failed callback Aug 14, 2019

@npracht npracht added this to Changes Requested / Review in Mautic 2 Aug 15, 2019

kuzmany added 10 commits Aug 15, 2019
Add CampaignDeliverySubscriber
Improve TransportSettings and TransportSettingsInterface
Remove CallbackReplyInterface and CallbackDeliveryInterface
Now getMessage could return array If we process multiple webhook results
Add ReplyDAO and fix unit tests
Allow multiple results from webhook as array of data objects

@kuzmany kuzmany changed the title Add support for sms delivered, read or failed callback SMS enhacements Aug 18, 2019

kuzmany added 2 commits Aug 18, 2019

@kuzmany kuzmany added Ready To Test and removed WIP labels Aug 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.