Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix convert all email images to embed type #7804

Open
wants to merge 3 commits into
base: staging
from

Conversation

@kuzmany
Copy link
Contributor

commented Aug 19, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR improve convert images to embed mode, If this option is enabled.

This fix allow convert images generate by plugin. For example
https://github.com/mtcextendee/mautic-barcode-generator-bundle

Steps to reproduce the bug:

  1. Create email and insert image
  2. Enable mailer_convert_embed_images from configuration
  3. Install https://github.com/mtcextendee/mautic-barcode-generator-bundle and insert {barcode=id} to email
  4. Send email
  5. See first image was embed and second image from token don't embed

Steps to test this PR:

  1. Repeat all steps
  2. See If both images are converted

@kuzmany kuzmany added this to the 2.16.0 milestone Aug 19, 2019

@kuzmany kuzmany changed the title Convert all email images to embed type Fix convert all email images to embed type Aug 19, 2019

@RCheesley
Copy link
Member

left a comment

Tested locally, able to reproduce pre-test and confirm that after applying the test, images from plugin are embedded along with other images. No other ill effects seen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.