Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Github directly for installing language packages #7813

Merged
merged 17 commits into from Mar 18, 2020

Conversation

@alanhartless
Copy link
Contributor

alanhartless commented Aug 22, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature? Y
Automated tests included? Y
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This simply changes Mautic to consume json configs from language files instead of PHP and changes from communicating through the legacy updates URL to using Github directly.

Steps to test this PR:

Community:

  1. Before installing the PR, ensure that a language is installed by changing the default locale in the Configuration
  2. Load up this PR
  3. Change the default locale through the Configuration to something that has not been used on the local installation before and click Apply. Look back at the locale list and it should have the language you chose selected.
  4. Log out and back in and the language should be used
  5. Run the migration php app/console doctrine:migrations:migrate. Look at the /translations folders. The language installed in step 1 should have a config.json instead of a config.php file.
@npracht

This comment has been minimized.

Copy link
Member

npracht commented Aug 26, 2019

@alanhartless can you have a look at Travis please?

@alanhartless

This comment has been minimized.

Copy link
Contributor Author

alanhartless commented Aug 26, 2019

Thanks @npracht! Not sure why my git hook is not working. Will see if I can get that resolved.

@npracht npracht added the L2 label Oct 4, 2019
@npracht npracht added this to the 2.16.0 milestone Oct 4, 2019
@RCheesley

This comment has been minimized.

Copy link
Member

RCheesley commented Oct 9, 2019

I've just been through the steps mentioned to test this, and indeed I see a config.json file.

However, what I am finding is that, although I've selected French as my language, both in the system settings and the user settings, I'm still seeing English.

I have logged out and logged back in, but still seeing the interface in English.

Not entirely sure if that is expected behaviour?

@mautic mautic deleted a comment from mautibot Oct 9, 2019
Copy link
Member

RCheesley left a comment

Actually, just cleared the cache and the language change has kicked in so confirming all is good! 👍

@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Oct 9, 2019
@kuzmany

This comment has been minimized.

Copy link
Contributor

kuzmany commented Oct 15, 2019

@alanhartless fix conflicts, please
Are you using it already on production?

@alanhartless alanhartless force-pushed the mautic-inc:enhancement.language-packages branch to 8aed74e Oct 18, 2019
Mautic 2 automation moved this from Ready to Test (confirmation) to Changes Requested / Review Oct 18, 2019
@alanhartless

This comment has been minimized.

Copy link
Contributor Author

alanhartless commented Oct 18, 2019

@kuzmany fixed the conflicts by rebasing. Yes, we are using it in production.

@escopecz

This comment has been minimized.

Copy link
Member

escopecz commented Dec 12, 2019

Same branch against the 3.x branch: #8226

Interesting is that Travis at least runs on that new PR...

@npracht npracht removed this from the 2.16.0 milestone Jan 23, 2020
@npracht npracht added this to the 2.16.1 milestone Feb 18, 2020
@alanhartless alanhartless force-pushed the mautic-inc:enhancement.language-packages branch from 8aed74e to 0cc3eae Feb 21, 2020
@alanhartless

This comment has been minimized.

Copy link
Contributor Author

alanhartless commented Feb 22, 2020

Seems the tests are passing now but not sure why scrutinizer is failing and giving a 503.

@dennisameling

This comment has been minimized.

Copy link
Member

dennisameling commented Mar 9, 2020

Closing and re-opening this PR so that Scrutinizer can run again. Should work then

@dennisameling dennisameling reopened this Mar 9, 2020
@npracht npracht added this to Needs a second test/review in Mautic 2 Mar 10, 2020
@RCheesley

This comment has been minimized.

Copy link
Member

RCheesley commented Mar 10, 2020

Setting as RTC based on test and comments re. use in production.

@RCheesley RCheesley moved this from Needs a second test/review to Ready to Commit (passed testing) in Mautic 2 Mar 10, 2020
Copy link
Member

dennisameling left a comment

Code looks good 👍

@dennisameling dennisameling merged commit 5c29cf9 into mautic:staging Mar 18, 2020
2 checks passed
2 checks passed
Scrutinizer Analysis: 7 new issues, 19 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged Mar 18, 2020
@mautibot

This comment has been minimized.

Copy link

mautibot commented Mar 20, 2020

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/announcing-mautic-2-16-1-beta/13438/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mautic 2
  
Merged
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.