Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report not showing properly clicks for multiple emails #7834

Merged

Conversation

@ondrejsibl
Copy link
Contributor

ondrejsibl commented Aug 29, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? N
Automated tests included? N
Related user documentation PR URL N
Related developer documentation PR URL N
Issues addressed (#s or URLs)
BC breaks? N
Deprecations? N

Description:

Reports for Emails sent data source based on more than one email are showing clicks only for the first email.

Steps to reproduce the bug:

  1. Create a report using Emails sent datasource
  2. Create two filters for Email ID with OR condition
  3. Clicks are displayed only for the first email

Steps to test this PR:

  1. Load up this PR
  2. Create a report using Emails sent datasource
  3. Create two filters for Email ID with OR condition
  4. Clicks are displayed for both emails
@npracht npracht added the Reports label Oct 4, 2019
@RCheesley RCheesley added this to the 2.16.1 milestone Mar 9, 2020
@npracht npracht added this to Ready to test in Mautic 2 Mar 10, 2020
@dennisameling dennisameling added the L1 label Mar 18, 2020
Copy link
Member

RCheesley left a comment

Confirmed bug without PR, and when applying PR stats from both emails are coming through! 👍 Thanks for the PR!

@RCheesley RCheesley moved this from Ready to test to Needs a second test/review in Mautic 2 Mar 18, 2020
@dennisameling

This comment has been minimized.

Copy link
Member

dennisameling commented Mar 19, 2020

Can confirm the issue:

image

Works properly after applying this PR 👍 thanks!

@dennisameling dennisameling merged commit 16b47b7 into mautic:staging Mar 19, 2020
2 checks passed
2 checks passed
Scrutinizer Analysis: 4 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Mautic 2 automation moved this from Needs a second test/review to Merged Mar 19, 2020
@mautibot

This comment has been minimized.

Copy link

mautibot commented Mar 20, 2020

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/announcing-mautic-2-16-1-beta/13438/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mautic 2
  
Merged
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.