Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing "PHP Notice - Undefined variable: submissions" #7839

Merged
merged 1 commit into from Sep 1, 2019

Conversation

@escopecz
Copy link
Member

commented Aug 31, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? N
Automated tests included? /
Related user documentation PR URL /
Related developer documentation PR URL /
Issues addressed (#s or URLs) #7135
BC breaks? N
Deprecations? N

Description:

This PR fixes a PHP notice about undefined variable. More details in the linked issue.

Steps to reproduce the bug:

  1. Ensure you have a Mautic form created.
  2. Create a new focus item
  3. In the builder select that you want to collect data
  4. Select a form to show.
  5. Check the logs. The notice will be recorded there. Or in case you use index_dev.php, it will display the notice in the UI.

Steps to test this PR:

  1. Load up this PR
  2. Repeat the steps. No notice will show up.
  3. The focus item still works in the builder and in the page for the contacts.
@Woeler
Woeler approved these changes Sep 1, 2019
Copy link
Member

left a comment

Confirmed error pre-test and once patch applied, no errors are showing and the form works fine when tested on Mautic landing pages.

@Woeler Woeler merged commit 0a710c9 into mautic:staging Sep 1, 2019
2 checks passed
2 checks passed
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.