Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative date support to anniversary #7853

Merged

Conversation

@Enc3phale
Copy link
Contributor

Enc3phale commented Sep 6, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature? N
Automated tests included?
Related user documentation PR URL mautic/documentation#299
Related developer documentation PR URL N
Issues addressed (#s or URLs) N
BC breaks? N
Deprecations? N

Description:

This PR re-add support relative dates to anniversary added with #6993 but broken by #7244

I added TU.

Steps to test this PR:

  1. Load up this PR
  2. Create date contact custom field
  3. Setup this field with date to anniversary with -7 days
    For example: If today is 11. 12. 2018 setup this field for 4. 12. 2010
  4. Create segment with this custom field filter and add equals and value of filter: anniversary -7 days
  5. Your contact should be added to segment
  6. If you change contacts custom field value to 3. 12. 2010, contact should be removed from segment.
Copy link

florentpetitjean left a comment

Tested and approved, working again.

@npracht npracht added the L1 label Oct 4, 2019
@npracht npracht added this to the 2.16.0 milestone Oct 4, 2019
@npracht npracht removed this from the 2.16.0 milestone Jan 23, 2020
@RCheesley RCheesley added this to the 2.16.1 milestone Mar 9, 2020
@npracht npracht added this to Needs a second test/review in Mautic 2 Mar 10, 2020
Copy link
Member

RCheesley left a comment

Tested on Mautibox and working as expected

@RCheesley RCheesley moved this from Needs a second test/review to Ready to Commit (passed testing) in Mautic 2 Mar 10, 2020
@dennisameling dennisameling merged commit 584ce0f into mautic:staging Mar 11, 2020
2 checks passed
2 checks passed
Scrutinizer Analysis: 1 new issues, 5 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged Mar 11, 2020
@mautibot

This comment has been minimized.

Copy link

mautibot commented Mar 20, 2020

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/announcing-mautic-2-16-1-beta/13438/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mautic 2
  
Merged
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.