Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow save image to contact profile from form #7886

Open
wants to merge 15 commits into
base: staging
from

Conversation

@kuzmany
Copy link
Contributor

kuzmany commented Sep 24, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR allow upload image directly to contact profile from forms.

image

Steps to test this PR:

  1. Load up this PR
  2. Create form with file field
  3. See properties tab and enable option "Set as profile image"
  4. Submit form
  5. See If image uploaded by form was set to contact profile.
@kuzmany kuzmany added this to the 2.16.0 milestone Sep 30, 2019
@npracht npracht added this to Ready to Test (first time) in Mautic 2 Oct 3, 2019
kuzmany added 6 commits Oct 3, 2019
Copy link
Member

RCheesley left a comment

Nice feature! Tested as instructed and the profile pic was indeed added to the contact.

One question though, I did wonder (as a user) why the profile image wasn't available as a matching field in the way you would usually associate a form field with a Mautic field. As this is the way most users will associate form data with Mautic fields, perhaps that's where we should have the ability to match the field?

Maybe that could be a better way of doing it than having another yes/no switch cluttering the UI? I'm not sure on the technical restrictions that this might present, so just a suggestion.

Copy link

oltmanns-leuchtfeuer left a comment

Testet it and it worked like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mautic 2
  
Ready to Test (first time)
3 participants
You can’t perform that action at this time.