Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All columns for agregators in Reports #7919

Open
wants to merge 4 commits into
base: staging
from

Conversation

@kuzmany
Copy link
Contributor

kuzmany commented Oct 3, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR just add allow all columns use in aggregate columns. After update we are able to use AVG of unsubscribe ratio etc.

image

Also I noticed impossible use Page hit ID in Page Hits reports.
This PR fixed it.

image

Steps to reproduce the bug:

1 Create emails type of report and group by something (category id for example)
2. Try set unsubscribe or unsubscribe ratio (for example SUM unsubscribed or AVG unsubscribe ratio)
3. You are not able to do that
4. Then try create page hits report.
5. Try find ID of hit. You can use just ID (it's pages table ID)

Steps to test this PR:

  1. Load up this PR
  2. You are able to choose unsubscribe and unsubscribe ration for aggregator columns (for example SUM unsubscribed or AVG unsubscribe ratio)
  3. Check if report works for you
  4. Then try create page hits report
  5. Try find ID of hit. You can use ID and Page hit ID
    ID is landing page ID , and Page hit ID is hit ID
@kuzmany kuzmany added this to the 2.16.0 milestone Oct 3, 2019
@npracht npracht added Reports L1 labels Oct 3, 2019
Copy link
Member

npracht left a comment

With the coming commit (that fixes an issue with the JS interface) it works as expected 👍

@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Oct 8, 2019
Mautic 2 automation moved this from Ready to Test (confirmation) to Changes Requested / Review Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mautic 2
  
Changes Requested / Review
2 participants
You can’t perform that action at this time.