Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preferences center segments ordering #7978

Open
wants to merge 2 commits into
base: staging
from

Conversation

@kuzmany
Copy link
Contributor

kuzmany commented Oct 24, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR fixed wrong segment choices ordering on preferences center page.

Steps to reproduce the bug:

  1. Create segments: a, b, c as Available in Preference Center
  2. Enable preferences center in Configuration > Emails and enable segments in preferences center
  3. Send email to contact and click to unsubscribe link
  4. You should see wrong segments order - from Z to A

Steps to test this PR:

  1. Load up this PR
  2. See segmetns ordering works properly now

image

@kuzmany kuzmany added this to the 2.16.0 milestone Oct 24, 2019
@kuzmany kuzmany changed the title Fix preferences center segment ordering Fix preferences center segments ordering Oct 24, 2019
Copy link

florentpetitjean left a comment

tested and working fine
Thanks

Copy link

florentpetitjean left a comment

Hello @kuzmany , this seems to not working with preference center using a theme, this works fine with default preference enter (no center selected in email) but not with a user created theme (landing page set as preference center)

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Oct 25, 2019

@florentpetitjean fixed with last commit. Please re-test

Copy link

florentpetitjean left a comment

Works well now.

Thanks

Copy link

florentpetitjean left a comment

Works with last commit, thanks.

@npracht npracht added the L1 label Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.