Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hidden bar If allow hide is disabled #8038

Open
wants to merge 1 commit into
base: staging
from

Conversation

@kuzmany
Copy link
Contributor

kuzmany commented Oct 29, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

We noticed Focus bar type not display If option Allow to hide is disabled.
This PR fixed it.

Steps to reproduce the bug:

  1. Create a focus item
  2. Set Display a notice
  3. Set "bar" as style
  4. Here, disable the "Allow to hide" option
  5. Set colors and enter text if you want.
  6. Save your focus.
  7. Create a landing page with the focus token in it. Or insert the focus script on a site.
  8. See that the focus is a blank bar.

Steps to test this PR:

  1. Load up this PR
  2. Repeat all steps to reproduce
  3. Check If works for both states of Allow to hide option

List deprecations along with the new alternative:

List backwards compatibility breaks:

@kuzmany kuzmany added this to the 2.16.0 milestone Oct 29, 2019
Copy link

florentpetitjean left a comment

Tested and works well
Thanks

Copy link

oltmanns-leuchtfeuer left a comment

Also tested it and the fix worked like a charm. Keep up the great work!

@npracht

This comment has been minimized.

Copy link
Member

npracht commented Oct 30, 2019

@oltmanns-leuchtfeuer thanks for testing. Be careful when you review to put approve instead of comment if that's all right for you ;)

@npracht npracht added this to Ready to Commit (passed testing) in Mautic 2 Oct 30, 2019
@oltmanns-leuchtfeuer

This comment has been minimized.

Copy link

oltmanns-leuchtfeuer commented Oct 30, 2019

Thanks for the advice @npracht :) I will watch out to correctly approve my tests instead of just commenting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mautic 2
  
Ready to Commit (passed testing)
4 participants
You can’t perform that action at this time.