Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cancel scheduled campaign event log #8116

Open
wants to merge 1 commit into
base: staging
from

Conversation

@kuzmany
Copy link
Contributor

kuzmany commented Nov 8, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

I noticed schedule campaign actions cannot cancel via timeline. This PR should fixed it.

image

@alanhartless As campaign refactoring author, this is just way how to cancel scheduling (set isScheduled to false)? Does it correct?

Steps to reproduce the bug:

  1. Create campaign
  2. Setup scheduled event (Change contacts tags for example)
  3. Trigger campaign
  4. Go to contact profile and see schedule campaign event action
  5. Try cancel it
  6. Reload page and see schedule event action still exists

Steps to test this PR:

  1. Load up this PR
  2. Repeat all steps and see If scheduled action is non scheduled now
@kuzmany kuzmany added the Bug label Nov 8, 2019
@kuzmany kuzmany added this to the 2.16.0 milestone Nov 8, 2019
@npracht npracht requested a review from alanhartless Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.