Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support include on of for multiselect segment filter #8169

Open
wants to merge 2 commits into
base: staging
from

Conversation

@kuzmany
Copy link
Contributor

kuzmany commented Nov 28, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR added support for include one of expression for multi select field.
By default include/exclude expect selected values in condition.
Include one of expect at least on of selected value.

For example:

  • include - if we expect fruit in filter - orange, lemon - contact must these values in profile
  • Include one of- If we expect fruit in filter - orange, lemon - contact could have at least one of them in profile

image

Steps to test this PR:

  1. Load up this PR. On your own test enviroment require assets generate php app/console m馃叞锔g
  2. Create multiselect contact field with multiple options
  3. Create segment with filter Include one of some values of that multiselect field
  4. Create contact with one of that values
  5. Segment rebuild
  6. Your contact should build in your segment
  7. If you change expression from Include one of to include, you contact should not be passed by segment filter and should remove from it
@kuzmany kuzmany added this to the 2.16.0 milestone Nov 28, 2019
@kuzmany kuzmany changed the title Support contains for multiselect segment filter Support include on of for multiselect segment filter Nov 29, 2019
@kuzmany kuzmany added Ready To Test and removed WIP labels Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.