Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor onCampaignTriggerActionSendEmailToUser #8172

Open
wants to merge 4 commits into
base: m2-to-m3
from

Conversation

@kuzmany
Copy link
Contributor

kuzmany commented Nov 29, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #8058
BC breaks?
Deprecations?

Description:

#8058

Steps to test this PR:

  1. Load up this PR
  2. Create campaign with action Send email to user
  3. Trigger campaign and check if email was sent to user properly
@kuzmany kuzmany added this to the 3.0.0 milestone Nov 29, 2019
@hluchas hluchas self-requested a review Dec 6, 2019
@hluchas

This comment has been minimized.

Copy link
Contributor

hluchas commented Dec 6, 2019

@kuzmany Can you fix conflict and tests? TY!

@escopecz

This comment has been minimized.

Copy link
Member

escopecz commented Dec 9, 2019

@kuzmany there are still some failing tests.

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Dec 12, 2019

@escopecz I am not able to rewrite unit tests in next few days. Sorry.
Can somebody from Mautic do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.