Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "If exist, not overwrite" to form to contact field mapping tab #8196

Open
wants to merge 4 commits into
base: staging
from

Conversation

@kuzmany
Copy link
Contributor

kuzmany commented Dec 5, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR added new option to form fields If exist, not overwrite.
This option don't allow overwrite lead field value If exists.

image

Steps to test this PR:

  1. Load up this PR
  2. Create form and set contact field mapping (firstname, lastname, email)
  3. Try submit form your contact should be overwritten
  4. Try submit again, with same email but different firstname, lastname. Your contact should be overwritten
  5. Now go to form, edit firstname field and enable new option If exist, not overwrite.
  6. Try submit again, with same email but different firstname, lastname. Your contact should be overwritten, but firstname shouldn't
kuzmany added 2 commits Dec 6, 2019
@kuzmany kuzmany changed the title Add Skip if exists to form to matching tab Add "If exist, not overwrite" to form to contact field mapping tab Dec 6, 2019
@kuzmany kuzmany added Ready To Test and removed WIP labels Dec 6, 2019
@johbuch

This comment has been minimized.

Copy link

johbuch commented Dec 6, 2019

@kuzmany I tested it only work if a contact already has a value.
For example my contact already has a firstname. So if I enable "If exist, not overwrite", then when I submit the form with another value, then it won't overtwrite so OK.

But if the contact does not have a value, so if it is empty in the database, then it won't work. The field will stay empty after the form submission.

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Dec 9, 2019

@johbuch fixed. please re-test

Copy link

johbuch left a comment

everything works now
thanks zdeno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.