Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timezone and preferred_locale to JS tracking event #8205

Open
wants to merge 1 commit into
base: staging
from

Conversation

@kuzmany
Copy link
Contributor

kuzmany commented Dec 9, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR added option to set timezone and preferred_locale from JS tracking code.

Timezone detection taken from https://github.com/Valve/fingerprintjs2/blob/master/fingerprint2.js#L443

Steps to test this PR:

  1. Load up this PR
  2. Set timezone and preferred_locale custom fields as Publicly updatable
    image
  3. Then add tracking code to your page
  4. Check If these fields were update based on your browser settings

image

Copy link

florentpetitjean left a comment

Tested and works great !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.