Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return unique clicked stats in email detail stats graph #8228

Open
wants to merge 4 commits into
base: staging
from

Conversation

@kuzmany
Copy link
Contributor

kuzmany commented Dec 12, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

We noticed graphs in segment email display total clicks for email.
But graph display data are related to send volume, then we expect clicked related to send volume.

Steps to reproduce the bug:

  1. Create segment email with two links
  2. Create two contacts and send segment email to contacts
  3. Open both emails and click few times on links
    4: Go to Email detail and see If graph show to many clicks. We expect 2 sent/read/clicked emails

Steps to test this PR:

  1. Load up this PR
  2. Repeat all steps and see If stats are correct
kuzmany added 3 commits Dec 17, 2019
@kuzmany kuzmany added Ready To Test and removed WIP labels Dec 17, 2019
Copy link

florentpetitjean left a comment

Works fine,
I got only 2 clicks in the graph testing as asked.
Good job !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.