Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inability to view contacts in mysql 8 #8455

Conversation

@anton-vlasenko
Copy link
Contributor

anton-vlasenko commented Feb 18, 2020

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #7612
BC breaks? N
Deprecations? N

Description:

It's impossible to view a contact on MySQL version 8.0.16 or later.
Probably this is caused by https://bugs.mysql.com/bug.php?id=95466

Steps to reproduce the bug:

  1. Install MySQL version 8.0.16 or later.
  2. Go to Contacts page, try to open (view) any contact.
  3. You will get a popup with the error message.

Steps to test this PR:

  1. Install MySQL version 8.0.16 or later.
  2. Load up this PR
  3. Go to Contacts page, try to open (view) any contact.
  4. You should be able to view contacts.
@anton-vlasenko anton-vlasenko force-pushed the mautic-inc:staging.fix-inability-to-view-contacts-in-mysql-8 branch to eb3691e Feb 18, 2020
@escopecz escopecz added this to the 2.16.1 milestone Feb 19, 2020
@escopecz escopecz linked an issue that may be closed by this pull request Feb 19, 2020
@escopecz escopecz added this to Ready to test in Mautic 2 Feb 19, 2020
Copy link

k2thels left a comment

This PR fixed the DATETIME error for me on both 2.16.0 and 3.0.0beta.

@escopecz escopecz moved this from Ready to test to Ready to Commit (passed testing) in Mautic 2 Mar 10, 2020
@dennisameling dennisameling merged commit a53edfc into mautic:staging Mar 10, 2020
2 checks passed
2 checks passed
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged Mar 10, 2020
@k2thels

This comment has been minimized.

Copy link

k2thels commented Mar 12, 2020

Will this pull request also be applied to Mautic 3?

@escopecz escopecz deleted the mautic-inc:staging.fix-inability-to-view-contacts-in-mysql-8 branch Mar 12, 2020
@escopecz

This comment has been minimized.

Copy link
Member

escopecz commented Mar 12, 2020

@k2thels it will. We merge all M2 releases to M3.

@mautibot

This comment has been minimized.

Copy link

mautibot commented Mar 20, 2020

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/announcing-mautic-2-16-1-beta/13438/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mautic 2
  
Merged
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.