Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Speed up leads custom fields" #8579

Merged
merged 2 commits into from Mar 19, 2020

Conversation

@dennisameling
Copy link
Member

dennisameling commented Mar 19, 2020

Reverts #7494

The PR above caused an issue with custom ordering in Mautic's API, see #7494 (comment)

In addition, this PR adds a note about the reason for why the "hack" is in place, in case someone comes across it in the future.

@dennisameling dennisameling requested review from alanhartless and RCheesley and removed request for alanhartless Mar 19, 2020
@dennisameling dennisameling added this to the 2.16.1 milestone Mar 19, 2020
@dennisameling dennisameling added this to Needs a second test/review in Mautic 2 Mar 19, 2020
Copy link
Member

dbhurley left a comment

+1

@dennisameling dennisameling merged commit a96b6d0 into staging Mar 19, 2020
3 checks passed
3 checks passed
Scrutinizer Analysis: 2 new issues, 1 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Mautic 2 automation moved this from Needs a second test/review to Merged Mar 19, 2020
@mautibot

This comment has been minimized.

Copy link

mautibot commented Mar 20, 2020

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/announcing-mautic-2-16-1-beta/13438/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mautic 2
  
Merged
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.