Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch for UnitOfWork warnings on PHP 7.3 #8583

Merged
merged 1 commit into from Mar 20, 2020
Merged

Add patch for UnitOfWork warnings on PHP 7.3 #8583

merged 1 commit into from Mar 20, 2020

Conversation

@dennisameling
Copy link
Member

dennisameling commented Mar 19, 2020

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? X
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Fixes #7843

Steps to reproduce the bug:

  1. Checkout the staging branch locally, no need to install Mautic. Just run composer install
  2. Run php build/package_release.php
  3. Open build/packaging/vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php on line 2636: it should say continue. Same for line 2665.

Steps to test this PR:

  1. Checkout this PR locally (git checkout fix-7843)
  2. Run rm -rf vendor just to be sure we have a clean state
  3. Run composer install
  4. Run php build/package_release.php
  5. Open build/packaging/vendor/doctrine/orm/lib/Doctrine/ORM/UnitOfWork.php on line 2636: it should say break. Same for line 2665.

List deprecations along with the new alternative:

  1. n/a

List backwards compatibility breaks:

  1. n/a - we're already on the latest 2.5 version of doctrine/ORM and it doesn't receive updates anymore (due to it being end of life), there won't be side effects for the 2.x branch of Mautic as we won't be updating Doctrine ORM to 2.6 or higher in this version anymore.
@dennisameling dennisameling added this to the 2.16.1 milestone Mar 19, 2020
Copy link
Member

RCheesley left a comment

Following instructions and outcome as expected. Thanks for the fix! 👍

@dennisameling dennisameling merged commit fd40a4d into staging Mar 20, 2020
3 checks passed
3 checks passed
Scrutinizer Analysis: 107 new issues, 93 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@dennisameling dennisameling deleted the fix-7843 branch Mar 20, 2020
@mautibot

This comment has been minimized.

Copy link

mautibot commented Mar 20, 2020

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/announcing-mautic-2-16-1-beta/13438/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.