Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix campaign trigger inactive schedule decision after scheduled event #9485

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Dec 10, 2020

Q A
Branch? 3.2
Bug fix? yes
New feature? no
Deprecations? no
BC breaks? no
Automated tests included? no
Related user documentation PR URL
Related developer documentation PR URL
Issue(s) addressed

Description:

Noticed ugly issue.
If you use scheduled event in campaigns, then events after false decision are triggered, even thought parent event was not triggered yet.

Steps to test this PR:

  1. Load up this PR
  2. Create campaign like this
  • action scheduled to 5 minutes
  • attach any decision
  • add to negative decision after 1 minute another action

image

  1. Add contact and trigger campaign
  2. Then re-add contact again and trigger campaign again
  3. Wait one minute and trigger campaign again
  4. Evet scheduled after decision is triggered even thought the parent event was not scheduled yet

@kuzmany kuzmany added bug Issues or PR's relating to bugs WIP PR's that are not ready for review and are currently in progress labels Dec 10, 2020
@kuzmany kuzmany added this to the 3.2.2 milestone Dec 10, 2020
@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Dec 10, 2020
@npracht npracht changed the base branch from features to 3.2 December 10, 2020 13:18
@npracht npracht changed the base branch from 3.2 to features December 10, 2020 13:18
@npracht
Copy link
Member

npracht commented Dec 10, 2020

@kuzmany please rebase against 3.2 please ?

@npracht npracht added the needs-rebase PR's that need to be rebased label Dec 10, 2020
@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #9485 (715149e) into 3.2 (d41e81d) will increase coverage by 0.09%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.2    #9485      +/-   ##
============================================
+ Coverage     31.84%   31.94%   +0.09%     
- Complexity    33595    33686      +91     
============================================
  Files          1946     1948       +2     
  Lines        115966   116213     +247     
============================================
+ Hits          36933    37123     +190     
- Misses        79033    79090      +57     
Impacted Files Coverage Δ Complexity Δ
...DashboardBundle/Controller/DashboardController.php 15.23% <45.00%> (+6.18%) 60.00 <3.00> (+4.00)
app/bundles/DashboardBundle/Dashboard/Widget.php 54.16% <54.16%> (ø) 9.00 <9.00> (?)
...s/EmailBundle/Command/ProcessEmailQueueCommand.php 76.92% <84.21%> (-0.46%) 30.00 <0.00> (+2.00) ⬇️
...s/CampaignBundle/Entity/LeadEventLogRepository.php 57.62% <100.00%> (+0.14%) 53.00 <0.00> (+1.00)
...p/bundles/DashboardBundle/Model/DashboardModel.php 17.02% <100.00%> (+17.02%) 30.00 <1.00> (ø)
...dles/EmailBundle/EventListener/PointSubscriber.php 73.91% <100.00%> (-6.09%) 9.00 <0.00> (-4.00)
...es/EmailBundle/EventListener/WebhookSubscriber.php 100.00% <100.00%> (+23.07%) 7.00 <3.00> (+3.00)
...p/bundles/EmailBundle/Model/SendEmailToContact.php 73.43% <100.00%> (ø) 42.00 <0.00> (ø)
app/bundles/FormBundle/Helper/FormFieldHelper.php 63.54% <100.00%> (+1.58%) 45.00 <0.00> (+4.00)
...dles/SmsBundle/EventListener/WebhookSubscriber.php 100.00% <100.00%> (ø) 4.00 <4.00> (?)
... and 9 more

@kuzmany kuzmany changed the base branch from features to 3.2 December 10, 2020 14:16
@npracht npracht changed the base branch from 3.2 to features December 10, 2020 14:18
@kuzmany kuzmany added needs-automated-tests PR's that need automated tests before they can be merged and removed WIP PR's that are not ready for review and are currently in progress labels Dec 10, 2020
@kuzmany kuzmany changed the base branch from features to 3.2 December 10, 2020 14:27
@kuzmany kuzmany force-pushed the fix-trigger-unactive-events-after-scheduled-event branch from cc885d5 to 715149e Compare December 10, 2020 14:28
@kuzmany kuzmany removed the bug Issues or PR's relating to bugs label Dec 10, 2020
@kuzmany kuzmany removed this from the 3.2.2 milestone Dec 10, 2020
@kuzmany
Copy link
Member Author

kuzmany commented Dec 10, 2020

Close favor to #9486

@kuzmany kuzmany closed this Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The PR contributors have signed the contributors agreement needs-automated-tests PR's that need automated tests before they can be merged needs-rebase PR's that need to be rebased
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants